fix(nx-infra-plugin): drop CRLF→LF normalization to preserve Windows CI artifacts

Author: chaosmirage

packages/nx-infra-plugin/src/executors/compress/executor.e2e.spec.ts

@@ -63,7 +63,7 @@ describe('CompressExecutor E2E', () => {
     expect(output.length).toBeLessThan(SAMPLE_CODE.length);
   });
 
-  it('should apply normalize: normalize CRLF to LF, ensure trailing newline, preserve debug blocks', async () => {
+  it('should apply normalize: ensure trailing newline, preserve debug blocks and original line endings', async () => {
     const filePath = path.join(projectDir, 'test.js');
     const crlfContent = SAMPLE_CODE.replace(/\n/g, '\r\n');
     await writeFileText(filePath, crlfContent);
@@ -78,7 +78,7 @@ describe('CompressExecutor E2E', () => {
 
     const output = await readFileText(filePath);
 
-    expect(output).not.toContain('\r\n');
+    expect(output).toContain('\r\n');
     expect(output.endsWith('\n')).toBe(true);
     expect(output).toContain('#DEBUG');
     expect(output).toContain('debug only');
@@ -141,8 +141,6 @@ describe('CompressExecutor E2E', () => {
 
     expect(output).toContain('function hello');
     expect(output.split('\n').length).toBeGreaterThan(3);
-
-    expect(output).not.toContain('\r\n');
   });
 
   it('should expand glob patterns in files array', async () => {
@@ -201,25 +199,6 @@ describe('CompressExecutor E2E', () => {
     expect(output.endsWith('\n')).toBe(false);
   });
 
-  it('should normalize CRLF to LF in strip-debug mode', async () => {
-    const filePath = path.join(projectDir, 'test.js');
-    const crlfContent = SAMPLE_CODE.replace(/\n/g, '\r\n');
-    await writeFileText(filePath, crlfContent);
-
-    const options: CompressExecutorSchema = {
-      files: ['./test.js'],
-      mode: 'strip-debug',
-    };
-
-    const result = await executor(options, context);
-    expect(result.success).toBe(true);
-
-    const output = await readFileText(filePath);
-    expect(output).not.toContain('\r\n');
-    expect(output).not.toContain('\r');
-    expect(output).toContain('function hello');
-  });
-
   it('should skip trailing newline in minify mode (compress:bundles:prod -c production parity)', async () => {
     const filePath = path.join(projectDir, 'test.js');
     await writeFileText(filePath, SAMPLE_CODE);

packages/nx-infra-plugin/src/executors/compress/executor.ts

@@ -7,12 +7,7 @@ import { minimatch } from 'minimatch';
 import { CompressExecutorSchema, CompressMode, CompressModeName } from './schema';
 import { resolveProjectPath, normalizeGlobPathForWindows } from '../../utils/path-resolver';
 import { isWindowsOS, containsGlobPattern } from '../../utils/common';
-import {
-  readFileText,
-  writeFileText,
-  normalizeEol,
-  ensureTrailingNewline,
-} from '../../utils/file-operations';
+import { readFileText, writeFileText, ensureTrailingNewline } from '../../utils/file-operations';
 
 // NOTE:
 // Removes the #DEBUG section from the code in the production build.
@@ -90,9 +85,8 @@ function stripDebugBlocks(content: string): string {
   return content.replace(REMOVE_DEBUG_REGEXP, '');
 }
 
-function normalizeOutput(content: string, trailingNewline: boolean): string {
-  const eolNormalized = normalizeEol(content);
-  return trailingNewline ? ensureTrailingNewline(eolNormalized) : eolNormalized;
+function appendTrailingNewline(content: string, trailingNewline: boolean): string {
+  return trailingNewline ? ensureTrailingNewline(content) : content;
 }
 
 type ResolvedMode = {
@@ -116,12 +110,13 @@ type CompressStrategy = (content: string, mode: ResolvedMode) => Promise<string>
 
 const STRATEGIES: Record<CompressModeName, CompressStrategy> = {
   minify: async (content, { eulaUrl, trailingNewline }) =>
-    normalizeOutput(await runMinify(stripDebugBlocks(content), eulaUrl), trailingNewline),
+    appendTrailingNewline(await runMinify(stripDebugBlocks(content), eulaUrl), trailingNewline),
   beautify: async (content, { eulaUrl, trailingNewline }) =>
-    normalizeOutput(await runBeautify(content, eulaUrl), trailingNewline),
+    appendTrailingNewline(await runBeautify(content, eulaUrl), trailingNewline),
   'strip-debug': async (content, { trailingNewline }) =>
-    normalizeOutput(stripDebugBlocks(content), trailingNewline),
-  normalize: async (content, { trailingNewline }) => normalizeOutput(content, trailingNewline),
+    appendTrailingNewline(stripDebugBlocks(content), trailingNewline),
+  normalize: async (content, { trailingNewline }) =>
+    appendTrailingNewline(content, trailingNewline),
 };
 
 async function compressFile(filePath: string, mode: CompressMode): Promise<void> {

packages/nx-infra-plugin/src/executors/vectormap/executor.ts

@@ -8,7 +8,6 @@ import {
   ensureDir,
   readFileText,
   writeFileText,
-  normalizeEol,
   ensureTrailingNewline,
 } from '../../utils/file-operations';
 
@@ -59,7 +58,7 @@ async function buildUtilsVariant(
   const compiled = _.template(utilsTemplate);
   let bundle = compiled({ data: concatenated });
 
-  bundle = ensureTrailingNewline(normalizeEol(bundle));
+  bundle = ensureTrailingNewline(bundle);
 
   const outputPath = path.join(outDir, `${variant.fileName}${variant.suffix}.js`);
   await writeFileText(outputPath, bundle);
@@ -141,7 +140,7 @@ async function writeRegionModules(
   for (const { name, data } of regions) {
     const rawData = `${name} = ${JSON.stringify(data)};`;
     let wrapped = USE_STRICT_HEADER + compiled({ data: rawData });
-    wrapped = ensureTrailingNewline(normalizeEol(wrapped));
+    wrapped = ensureTrailingNewline(wrapped);
     await writeFileText(path.join(outDir, `${name}.js`), wrapped);
   }
 }