Skip to content

Commit 6acbcf2

Browse files
sparistXmader
authored andcommitted
Treat V8 platform symbols same as base
This exports V8 platform symbols in the Node shared library build.
1 parent ea6301c commit 6acbcf2

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

tools/v8_gypfiles/v8.gyp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1686,10 +1686,7 @@
16861686
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?sources = ")',
16871687
],
16881688
'conditions': [
1689-
['component=="shared_library"', {
1690-
'direct_dependent_settings': {
1691-
'defines': ['USING_V8_PLATFORM_SHARED'],
1692-
},
1689+
['is_component_build', {
16931690
'defines': ['BUILDING_V8_PLATFORM_SHARED'],
16941691
}],
16951692
['v8_use_perfetto==1', {

0 commit comments

Comments
 (0)