Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore: Add naman-tiwar#1133

Merged
Pradumnasaraf merged 4 commits intoEddieHubCommunity:mainfrom
naman-tiwari:naman-tiwari
Aug 6, 2022
Merged

chore: Add naman-tiwar#1133
Pradumnasaraf merged 4 commits intoEddieHubCommunity:mainfrom
naman-tiwari:naman-tiwari

Conversation

@naman-tiwari
Copy link
Copy Markdown
Contributor

@naman-tiwari naman-tiwari commented Jun 14, 2022 •
edited
Loading

Add naman-tiwari

github-actions[bot]
github-actions bot reviewed Jun 14, 2022
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source, little and often 🤓 . Any questions let us know.

Pradumnasaraf
Pradumnasaraf suggested changes Jun 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove that extra line!

__
sema-logo  Summary: 🛠️ This code needs a fix

@Pradumnasaraf Pradumnasaraf changed the title added username chore: Add naman-tiwar Jun 14, 2022
Pradumnasaraf
Pradumnasaraf suggested changes Jun 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still one extra added and removed, please fix that.

If you have any doubt feel free to reach out

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Reusable

Pradumnasaraf
Pradumnasaraf approved these changes Aug 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge!

__
sema-logo  Summary: 👌 This code looks good  |  Tags: Reusable

@Pradumnasaraf Pradumnasaraf merged commit 0476683 into EddieHubCommunity:main Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Pradumnasaraf Pradumnasaraf Pradumnasaraf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@naman-tiwari @Pradumnasaraf
⚡