Fix class self mismatch for ServiceMap services (#690)

Author: mattiamanzati

.changeset/hot-walls-share.md

@@ -0,0 +1,5 @@
+---
+"@effect/language-service": patch
+---
+
+Fix the class self mismatch diagnostic so it also reports invalid `ServiceMap.Service` self type parameters.

packages/harness-effect-v4/__snapshots__/diagnostics/classSelfMismatch_service.ts.classSelfMismatch_fix.from317to328.output

@@ -0,0 +1,12 @@
+// code fix classSelfMismatch_fix  output for range 317 - 328
+import { ServiceMap, Effect } from "effect"
+
+export class CorrectName extends ServiceMap.Service<CorrectName, {
+    writeCache: () => Effect.Effect<void, never, FileSystem | Cache>
+    readCache: Effect.Effect<void, never, FileSystem | Cache>
+}>()("CorrectName") {}
+
+export class WrongName extends ServiceMap.Service<WrongName, {
+    writeCache: () => Effect.Effect<void, never, FileSystem | Cache>
+    readCache: Effect.Effect<void, never, FileSystem | Cache>
+}>()("WrongName") {}

packages/harness-effect-v4/__snapshots__/diagnostics/classSelfMismatch_service.ts.codefixes

@@ -0,0 +1,3 @@
+classSelfMismatch_fix from 317 to 328
+classSelfMismatch_skipNextLine from 317 to 328
+classSelfMismatch_skipFile from 317 to 328

packages/harness-effect-v4/__snapshots__/diagnostics/classSelfMismatch_service.ts.output

@@ -0,0 +1,2 @@
+CorrectName
+8:50 - 8:61 | 1 | Self type parameter should be 'WrongName'    effect(classSelfMismatch)

packages/harness-effect-v4/examples/diagnostics/classSelfMismatch_service.ts

@@ -0,0 +1,11 @@
+import { ServiceMap, Effect } from "effect"
+
+export class CorrectName extends ServiceMap.Service<CorrectName, {
+    writeCache: () => Effect.Effect<void, never, FileSystem | Cache>
+    readCache: Effect.Effect<void, never, FileSystem | Cache>
+}>()("CorrectName") {}
+
+export class WrongName extends ServiceMap.Service<CorrectName, {
+    writeCache: () => Effect.Effect<void, never, FileSystem | Cache>
+    readCache: Effect.Effect<void, never, FileSystem | Cache>
+}>()("WrongName") {}

packages/language-service/src/diagnostics/classSelfMismatch.ts

@@ -32,6 +32,7 @@ export const classSelfMismatch = LSP.createDiagnostic({
         // Check if this class extends a class that has a Self type parameter
         const result = yield* pipe(
           typeParser.extendsEffectService(node),
+          Nano.orElse(() => typeParser.extendsServiceMapService(node)),
           Nano.orElse(() => typeParser.extendsContextTag(node)),
           Nano.orElse(() => typeParser.extendsEffectTag(node)),
           Nano.orElse(() => typeParser.extendsSchemaClass(node)),