Add globalDate, globalConsole, globalRandom, globalTimers diagnostics (#696)

Author: cevr

.changeset/global-diagnostics.md

@@ -0,0 +1,14 @@
+---
+"@effect/language-service": minor
+---
+
+Add globalDate, globalConsole, globalRandom, and globalTimers diagnostics
+
+Four new opt-in diagnostics that flag global/DOM APIs inside Effect generators:
+
+- `globalDate` — `Date.now()`, `new Date()` → Clock/DateTime
+- `globalConsole` — `console.log/warn/error/info/debug/trace` → Effect.log/Logger
+- `globalRandom` — `Math.random()` → Random service
+- `globalTimers` — `setTimeout/setInterval` → Effect.sleep/Schedule
+
+All default to `off`. Shadow-safe (e.g. `const console = yield* Console` won't false-positive).

README.md

@@ -89,7 +89,11 @@ Some diagnostics are off by default or have a default severity of suggestion, bu
     <tr><td><code>unknownInEffectCatch</code></td><td>⚠️</td><td></td><td>Warns when catch callbacks return unknown instead of typed errors</td><td>✓</td><td>✓</td></tr>
     <tr><td colspan="6"><strong>Effect-native</strong> <em>Prefer Effect-native APIs and abstractions when available.</em></td></tr>
     <tr><td><code>extendsNativeError</code></td><td>➖</td><td></td><td>Warns when a class directly extends the native Error class</td><td>✓</td><td>✓</td></tr>
+    <tr><td><code>globalConsole</code></td><td>➖</td><td></td><td>Warns when using console methods inside Effect generators instead of Effect.log/Logger</td><td>✓</td><td>✓</td></tr>
+    <tr><td><code>globalDate</code></td><td>➖</td><td></td><td>Warns when using Date.now() or new Date() inside Effect generators instead of Clock/DateTime</td><td>✓</td><td>✓</td></tr>
     <tr><td><code>globalFetch</code></td><td>➖</td><td></td><td>Warns when using the global fetch function instead of the Effect HTTP client</td><td>✓</td><td>✓</td></tr>
+    <tr><td><code>globalRandom</code></td><td>➖</td><td></td><td>Warns when using Math.random() inside Effect generators instead of the Random service</td><td>✓</td><td>✓</td></tr>
+    <tr><td><code>globalTimers</code></td><td>➖</td><td></td><td>Warns when using setTimeout/setInterval inside Effect generators instead of Effect.sleep/Schedule</td><td>✓</td><td>✓</td></tr>
     <tr><td><code>instanceOfSchema</code></td><td>➖</td><td>🔧</td><td>Suggests using Schema.is instead of instanceof for Effect Schema types</td><td>✓</td><td>✓</td></tr>
     <tr><td><code>nodeBuiltinImport</code></td><td>➖</td><td></td><td>Warns when importing Node.js built-in modules that have Effect-native counterparts</td><td>✓</td><td>✓</td></tr>
     <tr><td><code>preferSchemaOverJson</code></td><td>💡</td><td></td><td>Suggests using Effect Schema for JSON operations instead of JSON.parse/JSON.stringify which may throw</td><td>✓</td><td>✓</td></tr>

packages/harness-effect-v3/__snapshots__/diagnostics/globalConsole.ts.codefixes

@@ -0,0 +1,6 @@
+globalConsole_skipNextLine from 195 to 215
+globalConsole_skipFile from 195 to 215
+globalConsole_skipNextLine from 346 to 369
+globalConsole_skipFile from 346 to 369
+globalConsole_skipNextLine from 486 to 508
+globalConsole_skipFile from 486 to 508

packages/harness-effect-v3/__snapshots__/diagnostics/globalConsole.ts.output

@@ -0,0 +1,11 @@
+console.log("hello")
+6:2 - 6:22 | 0 | Prefer using Effect.log or Logger instead of console.log inside Effect generators.    effect(globalConsole)
+
+console.warn("warning")
+11:2 - 11:25 | 0 | Prefer using Effect.logWarning or Logger instead of console.warn inside Effect generators.    effect(globalConsole)
+
+console.error("error")
+16:2 - 16:24 | 0 | Prefer using Effect.logError or Logger instead of console.error inside Effect generators.    effect(globalConsole)
+
+myConsole.log("hello")
+22:2 - 22:24 | 0 | Prefer using Effect.log or Logger instead of console.log inside Effect generators.    effect(globalConsole)

packages/harness-effect-v3/__snapshots__/diagnostics/globalConsole_preview.ts.codefixes

@@ -0,0 +1,2 @@
+globalConsole_skipNextLine from 157 to 177
+globalConsole_skipFile from 157 to 177

packages/harness-effect-v3/__snapshots__/diagnostics/globalConsole_preview.ts.output

@@ -0,0 +1,2 @@
+console.log("hello")
+6:2 - 6:22 | 0 | Prefer using Effect.log or Logger instead of console.log inside Effect generators.    effect(globalConsole)

packages/harness-effect-v3/__snapshots__/diagnostics/globalDate.ts.codefixes

@@ -0,0 +1,6 @@
+globalDate_skipNextLine from 191 to 201
+globalDate_skipFile from 191 to 201
+globalDate_skipNextLine from 335 to 345
+globalDate_skipFile from 335 to 345
+globalDate_skipNextLine from 521 to 543
+globalDate_skipFile from 521 to 543

packages/harness-effect-v3/__snapshots__/diagnostics/globalDate.ts.output

@@ -0,0 +1,11 @@
+Date.now()
+6:14 - 6:24 | 0 | Prefer using Clock or DateTime from Effect instead of Date.now() inside Effect generators.    effect(globalDate)
+
+new Date()
+12:14 - 12:24 | 0 | Prefer using DateTime from Effect instead of new Date() inside Effect generators.    effect(globalDate)
+
+new Date("2024-01-01")
+18:15 - 18:37 | 0 | Prefer using DateTime from Effect instead of new Date() inside Effect generators.    effect(globalDate)
+
+MyDate.now()
+25:14 - 25:26 | 0 | Prefer using Clock or DateTime from Effect instead of Date.now() inside Effect generators.    effect(globalDate)

packages/harness-effect-v3/__snapshots__/diagnostics/globalDate_preview.ts.codefixes

@@ -0,0 +1,2 @@
+globalDate_skipNextLine from 166 to 176
+globalDate_skipFile from 166 to 176

packages/harness-effect-v3/__snapshots__/diagnostics/globalDate_preview.ts.output

@@ -0,0 +1,2 @@
+Date.now()
+6:14 - 6:24 | 0 | Prefer using Clock or DateTime from Effect instead of Date.now() inside Effect generators.    effect(globalDate)