Updated setPlaceholder( Node, Pos ) (#1036)

Author: Jugen

richtextfx/src/main/java/org/fxmisc/richtext/GenericStyledArea.java

@@ -8,6 +8,7 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
+import java.util.Objects;
 import java.util.Optional;
 import java.util.function.BiConsumer;
 import java.util.function.BiFunction;
@@ -392,11 +393,11 @@ public Node getParagraphGraphic( int parNdx ) {
      * <br>To customize the placeholder's layout override {@link #configurePlaceholder( Node )}
      */
     public final void setPlaceholder(Node value) { setPlaceholder(value,Pos.CENTER); }
-    public final void setPlaceholder(Node value, Pos where) { placeHolderProp.set(value); placeHolderPos = where; }
+    public void setPlaceholder(Node value, Pos where) { placeHolderProp.set(value); placeHolderPos = Objects.requireNonNull(where); }
     private ObjectProperty<Node> placeHolderProp = new SimpleObjectProperty<>(this, "placeHolder", null);
     public final ObjectProperty<Node> placeholderProperty() { return placeHolderProp; }
     public final Node getPlaceholder() { return placeHolderProp.get(); }
-    private Pos placeHolderPos;
+    private Pos placeHolderPos = Pos.CENTER;
 
     private ObjectProperty<ContextMenu> contextMenu = new SimpleObjectProperty<>(null);
     @Override public final ObjectProperty<ContextMenu> contextMenuObjectProperty() { return contextMenu; }
@@ -929,7 +930,7 @@ private void displayPlaceHolder( boolean show, Node newNode )
      */
     protected void configurePlaceholder( Node placeholder )
     {
-    	positionPlaceholder = true;
+        positionPlaceholder = true;
     }
 
     /* ********************************************************************** *
@@ -1691,10 +1692,10 @@ protected void layoutChildren() {
         });
 
         Node holder = placeholder;
-        if (holder != null && holder.isResizable() && holder.isManaged()) {
-            holder.autosize();
-            if ( positionPlaceholder ) Region.positionInArea
-        	(
+        if (holder != null && holder.isManaged()) {
+            if (holder.isResizable()) holder.autosize();
+            if (positionPlaceholder) Region.positionInArea
+            (
                 holder, getLayoutX(), getLayoutY(), getWidth(), getHeight(), getBaselineOffset(),
                 ins, placeHolderPos.getHpos(), placeHolderPos.getVpos(), isSnapToPixel()
             );

richtextfx/src/main/java/org/fxmisc/richtext/StyledTextField.java

@@ -19,6 +19,7 @@
 import javafx.css.StyleableObjectProperty;
 import javafx.event.ActionEvent;
 import javafx.event.EventHandler;
+import javafx.geometry.Pos;
 import javafx.scene.AccessibleRole;
 import javafx.scene.Group;
 import javafx.scene.Node;
@@ -213,9 +214,11 @@ public String getName() {
      * <p>The Text will be aligned according to the text fields alignment setting and have a default
      * text fill of GRAY unless you have changed it by any means, e.g. with CSS "-fx-prompt-text-fill" 
      */
+    public final void setPromptText( Text value ) { placeholderProperty().set( value ); }
     public final ObjectProperty<? super Text> promptTextProperty() { return placeholderProperty(); }
     public final Text getPromptText() { return getPlaceholder() instanceof Text ? (Text) getPlaceholder() : null; }
-    public final void setPromptText( Text value ) { setPlaceholder( value ); }
+    /** setPlaceholder is not supported by StyledTextField, use setPromptText instead */ 
+    @Override public void setPlaceholder( Node value, Pos where ) { throw new UnsupportedOperationException("Use setPromptText instead"); }
     @Override protected void configurePlaceholder( Node placeholder )
     {
         placeholder.layoutYProperty().bind( Bindings.createDoubleBinding( () ->