Identifier values are now of type string.

biozshock · biozshock · commit 0873c7d15e3f · 2025-02-25T15:02:47.000+01:00
@see `\Elastica\Bulk\Action::setId`
diff --git a/src/Doctrine/Listener.php b/src/Doctrine/Listener.php
@@ -195,7 +195,7 @@ private function persistScheduled()
     private function scheduleForDeletion($object)
     {
         if ($identifierValue = $this->propertyAccessor->getValue($object, $this->config['identifier'])) {
-            $this->scheduledForDeletion[] = !\is_scalar($identifierValue) ? (string) $identifierValue : $identifierValue;
+            $this->scheduledForDeletion[] = (string) $identifierValue;
         }
     }
 
diff --git a/src/Persister/ObjectPersister.php b/src/Persister/ObjectPersister.php
@@ -105,7 +105,7 @@ public function deleteOne($object)
 
     public function deleteById($id, $routing = false)
     {
-        $this->deleteManyByIdentifiers([$id], $routing);
+        $this->deleteManyByIdentifiers([(string) $id], $routing);
     }
 
     public function insertMany(array $objects)

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ private function persistScheduled()`
`195`	`195`	`private function scheduleForDeletion($object)`
`196`	`196`	`{`
`197`	`197`	`if ($identifierValue = $this->propertyAccessor->getValue($object, $this->config['identifier'])) {`
`198`		`- $this->scheduledForDeletion[] = !\is_scalar($identifierValue) ? (string) $identifierValue : $identifierValue;`
	`198`	`+ $this->scheduledForDeletion[] = (string) $identifierValue;`
`199`	`199`	`}`
`200`	`200`	`}`
`201`	`201`
Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ public function deleteOne($object)`
`105`	`105`
`106`	`106`	`public function deleteById($id, $routing = false)`
`107`	`107`	`{`
`108`		`- $this->deleteManyByIdentifiers([$id], $routing);`
	`108`	`+ $this->deleteManyByIdentifiers([(string) $id], $routing);`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`public function insertMany(array $objects)`