Skip to content

Commit b38d95e

Browse files
chore(format): run eslint and prettier separately
1 parent f13bb8b commit b38d95e

8 files changed

Lines changed: 13 additions & 53 deletions

File tree

.github/workflows/release-doctor.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,3 @@ jobs:
1919
bash ./bin/check-release-environment
2020
env:
2121
NPM_TOKEN: ${{ secrets.GRID_NPM_TOKEN || secrets.NPM_TOKEN }}
22-

eslint.config.mjs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// @ts-check
22
import tseslint from 'typescript-eslint';
33
import unusedImports from 'eslint-plugin-unused-imports';
4-
import prettier from 'eslint-plugin-prettier';
54

65
export default tseslint.config(
76
{
@@ -14,11 +13,9 @@ export default tseslint.config(
1413
plugins: {
1514
'@typescript-eslint': tseslint.plugin,
1615
'unused-imports': unusedImports,
17-
prettier,
1816
},
1917
rules: {
2018
'no-unused-vars': 'off',
21-
'prettier/prettier': 'error',
2219
'unused-imports/no-unused-imports': 'error',
2320
'no-restricted-imports': [
2421
'error',

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
"@typescript-eslint/eslint-plugin": "8.31.1",
3737
"@typescript-eslint/parser": "8.31.1",
3838
"eslint": "^9.39.1",
39-
"eslint-plugin-prettier": "^5.4.1",
4039
"eslint-plugin-unused-imports": "^4.1.4",
4140
"iconv-lite": "^0.6.3",
4241
"jest": "^29.4.0",

scripts/fast-format

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,7 @@ if ! [ -z "$ESLINT_FILES" ]; then
3131
fi
3232

3333
echo "==> Running prettier --write"
34-
# format things eslint didn't
35-
PRETTIER_FILES="$(grep '\.\(js\|json\)$' "$FILE_LIST" || true)"
36-
if ! [ -z "$PRETTIER_FILES" ]; then
37-
echo "$PRETTIER_FILES" | xargs ./node_modules/.bin/prettier \
38-
--write --cache --cache-strategy metadata --no-error-on-unmatched-pattern \
39-
'!**/dist' '!**/*.ts' '!**/*.mts' '!**/*.cts' '!**/*.js' '!**/*.mjs' '!**/*.cjs'
34+
if ! [ -z "$FILE_LIST" ]; then
35+
cat "$FILE_LIST" | xargs ./node_modules/.bin/prettier \
36+
--write --cache --cache-strategy metadata --no-error-on-unmatched-pattern --ignore-unknown
4037
fi

scripts/format

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@ echo "==> Running eslint --fix"
88
./node_modules/.bin/eslint --fix .
99

1010
echo "==> Running prettier --write"
11-
# format things eslint didn't
12-
./node_modules/.bin/prettier --write --cache --cache-strategy metadata . '!**/dist' '!**/*.ts' '!**/*.mts' '!**/*.cts' '!**/*.js' '!**/*.mjs' '!**/*.cjs'
11+
./node_modules/.bin/prettier --write --cache --cache-strategy metadata .

scripts/lint

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ set -e
44

55
cd "$(dirname "$0")/.."
66

7+
echo "==> Running prettier --check"
8+
./node_modules/.bin/prettier --check .
9+
710
echo "==> Running eslint"
811
./node_modules/.bin/eslint .
912

src/internal/types.ts

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ type OverloadedParameters<T> =
4040
: T extends (...args: infer A) => unknown ? A
4141
: never;
4242

43-
/* eslint-disable */
4443
/**
4544
* These imports attempt to get types from a parent package's dependencies.
4645
* Unresolved bare specifiers can trigger [automatic type acquisition][1] in some projects, which
@@ -63,19 +62,18 @@ type OverloadedParameters<T> =
6362
*
6463
* [1]: https://www.typescriptlang.org/tsconfig/#typeAcquisition
6564
*/
66-
/** @ts-ignore For users with \@types/node */
65+
/** @ts-ignore For users with \@types/node */ /* prettier-ignore */
6766
type UndiciTypesRequestInit = NotAny<import('../node_modules/undici-types/index.d.ts').RequestInit> | NotAny<import('../../node_modules/undici-types/index.d.ts').RequestInit> | NotAny<import('../../../node_modules/undici-types/index.d.ts').RequestInit> | NotAny<import('../../../../node_modules/undici-types/index.d.ts').RequestInit> | NotAny<import('../../../../../node_modules/undici-types/index.d.ts').RequestInit> | NotAny<import('../../../../../../node_modules/undici-types/index.d.ts').RequestInit> | NotAny<import('../../../../../../../node_modules/undici-types/index.d.ts').RequestInit> | NotAny<import('../../../../../../../../node_modules/undici-types/index.d.ts').RequestInit> | NotAny<import('../../../../../../../../../node_modules/undici-types/index.d.ts').RequestInit> | NotAny<import('../../../../../../../../../../node_modules/undici-types/index.d.ts').RequestInit>;
68-
/** @ts-ignore For users with undici */
67+
/** @ts-ignore For users with undici */ /* prettier-ignore */
6968
type UndiciRequestInit = NotAny<import('../node_modules/undici/index.d.ts').RequestInit> | NotAny<import('../../node_modules/undici/index.d.ts').RequestInit> | NotAny<import('../../../node_modules/undici/index.d.ts').RequestInit> | NotAny<import('../../../../node_modules/undici/index.d.ts').RequestInit> | NotAny<import('../../../../../node_modules/undici/index.d.ts').RequestInit> | NotAny<import('../../../../../../node_modules/undici/index.d.ts').RequestInit> | NotAny<import('../../../../../../../node_modules/undici/index.d.ts').RequestInit> | NotAny<import('../../../../../../../../node_modules/undici/index.d.ts').RequestInit> | NotAny<import('../../../../../../../../../node_modules/undici/index.d.ts').RequestInit> | NotAny<import('../../../../../../../../../../node_modules/undici/index.d.ts').RequestInit>;
70-
/** @ts-ignore For users with \@types/bun */
69+
/** @ts-ignore For users with \@types/bun */ /* prettier-ignore */
7170
type BunRequestInit = globalThis.FetchRequestInit;
72-
/** @ts-ignore For users with node-fetch@2 */
71+
/** @ts-ignore For users with node-fetch@2 */ /* prettier-ignore */
7372
type NodeFetch2RequestInit = NotAny<import('../node_modules/@types/node-fetch/index.d.ts').RequestInit> | NotAny<import('../../node_modules/@types/node-fetch/index.d.ts').RequestInit> | NotAny<import('../../../node_modules/@types/node-fetch/index.d.ts').RequestInit> | NotAny<import('../../../../node_modules/@types/node-fetch/index.d.ts').RequestInit> | NotAny<import('../../../../../node_modules/@types/node-fetch/index.d.ts').RequestInit> | NotAny<import('../../../../../../node_modules/@types/node-fetch/index.d.ts').RequestInit> | NotAny<import('../../../../../../../node_modules/@types/node-fetch/index.d.ts').RequestInit> | NotAny<import('../../../../../../../../node_modules/@types/node-fetch/index.d.ts').RequestInit> | NotAny<import('../../../../../../../../../node_modules/@types/node-fetch/index.d.ts').RequestInit> | NotAny<import('../../../../../../../../../../node_modules/@types/node-fetch/index.d.ts').RequestInit>;
74-
/** @ts-ignore For users with node-fetch@3, doesn't need file extension because types are at ./@types/index.d.ts */
73+
/** @ts-ignore For users with node-fetch@3, doesn't need file extension because types are at ./@types/index.d.ts */ /* prettier-ignore */
7574
type NodeFetch3RequestInit = NotAny<import('../node_modules/node-fetch').RequestInit> | NotAny<import('../../node_modules/node-fetch').RequestInit> | NotAny<import('../../../node_modules/node-fetch').RequestInit> | NotAny<import('../../../../node_modules/node-fetch').RequestInit> | NotAny<import('../../../../../node_modules/node-fetch').RequestInit> | NotAny<import('../../../../../../node_modules/node-fetch').RequestInit> | NotAny<import('../../../../../../../node_modules/node-fetch').RequestInit> | NotAny<import('../../../../../../../../node_modules/node-fetch').RequestInit> | NotAny<import('../../../../../../../../../node_modules/node-fetch').RequestInit> | NotAny<import('../../../../../../../../../../node_modules/node-fetch').RequestInit>;
76-
/** @ts-ignore For users who use Deno */
75+
/** @ts-ignore For users who use Deno */ /* prettier-ignore */
7776
type FetchRequestInit = NonNullable<OverloadedParameters<typeof fetch>[1]>;
78-
/* eslint-enable */
7977

8078
type RequestInits =
8179
| NotAny<UndiciTypesRequestInit>

yarn.lock

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -709,11 +709,6 @@
709709
"@nodelib/fs.scandir" "2.1.5"
710710
fastq "^1.6.0"
711711

712-
"@pkgr/core@^0.2.4":
713-
version "0.2.4"
714-
resolved "https://registry.yarnpkg.com/@pkgr/core/-/core-0.2.4.tgz#d897170a2b0ba51f78a099edccd968f7b103387c"
715-
integrity sha512-ROFF39F6ZrnzSUEmQQZUar0Jt4xVoP9WnDRdWwF4NNcXs3xBTLgBUDoOwW141y1jP+S8nahIbdxbFC7IShw9Iw==
716-
717712
"@sinclair/typebox@^0.27.8":
718713
version "0.27.8"
719714
resolved "https://registry.yarnpkg.com/@sinclair/typebox/-/typebox-0.27.8.tgz#6667fac16c436b5434a387a34dedb013198f6e6e"
@@ -1515,14 +1510,6 @@ escape-string-regexp@^4.0.0:
15151510
resolved "https://registry.yarnpkg.com/escape-string-regexp/-/escape-string-regexp-4.0.0.tgz#14ba83a5d373e3d311e5afca29cf5bfad965bf34"
15161511
integrity sha512-TtpcNJ3XAzx3Gq8sWRzJaVajRs0uVxA2YAkdb1jm2YkPz4G6egUFAyA3n5vtEIZefPk5Wa4UXbKuS5fKkJWdgA==
15171512

1518-
eslint-plugin-prettier@^5.4.1:
1519-
version "5.4.1"
1520-
resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-5.4.1.tgz#99b55d7dd70047886b2222fdd853665f180b36af"
1521-
integrity sha512-9dF+KuU/Ilkq27A8idRP7N2DH8iUR6qXcjF3FR2wETY21PZdBrIjwCau8oboyGj9b7etWmTGEeM8e7oOed6ZWg==
1522-
dependencies:
1523-
prettier-linter-helpers "^1.0.0"
1524-
synckit "^0.11.7"
1525-
15261513
eslint-plugin-unused-imports@^4.1.4:
15271514
version "4.1.4"
15281515
resolved "https://registry.yarnpkg.com/eslint-plugin-unused-imports/-/eslint-plugin-unused-imports-4.1.4.tgz#62ddc7446ccbf9aa7b6f1f0b00a980423cda2738"
@@ -1674,11 +1661,6 @@ fast-deep-equal@^3.1.1, fast-deep-equal@^3.1.3:
16741661
resolved "https://registry.yarnpkg.com/fast-deep-equal/-/fast-deep-equal-3.1.3.tgz#3a7d56b559d6cbc3eb512325244e619a65c6c525"
16751662
integrity sha512-f3qQ9oQy9j2AhBe/H9VC91wLmKBCCU/gDOnKNAYG5hswO7BLKj09Hc5HYNz9cGI++xlpDCIgDaitVs03ATR84Q==
16761663

1677-
fast-diff@^1.1.2:
1678-
version "1.3.0"
1679-
resolved "https://registry.yarnpkg.com/fast-diff/-/fast-diff-1.3.0.tgz#ece407fa550a64d638536cd727e129c61616e0f0"
1680-
integrity sha512-VxPP4NqbUjj6MaAOafWeUn2cXWLcCtljklUtZf0Ind4XQ+QPtmA0b18zZy0jIQx+ExRVCR/ZQpBmik5lXshNsw==
1681-
16821664
fast-glob@^3.3.2:
16831665
version "3.3.2"
16841666
resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.3.2.tgz#a904501e57cfdd2ffcded45e99a54fef55e46129"
@@ -2841,13 +2823,6 @@ prelude-ls@^1.2.1:
28412823
resolved "https://registry.yarnpkg.com/prelude-ls/-/prelude-ls-1.2.1.tgz#debc6489d7a6e6b0e7611888cec880337d316396"
28422824
integrity sha512-vkcDPrRZo1QZLbn5RLGPpg/WmIQ65qoWWhcGKf/b5eplkkarX0m9z8ppCat4mlOqUsWpyNuYgO3VRyrYHSzX5g==
28432825

2844-
prettier-linter-helpers@^1.0.0:
2845-
version "1.0.0"
2846-
resolved "https://registry.yarnpkg.com/prettier-linter-helpers/-/prettier-linter-helpers-1.0.0.tgz#d23d41fe1375646de2d0104d3454a3008802cf7b"
2847-
integrity sha512-GbK2cP9nraSSUF9N2XwUwqfzlAFlMNYYl+ShE/V+H8a9uNl/oUqB1w2EL54Jh0OlyRSd8RfWYJ3coVS4TROP2w==
2848-
dependencies:
2849-
fast-diff "^1.1.2"
2850-
28512826
prettier@^3.0.0:
28522827
version "3.1.1"
28532828
resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.1.1.tgz#6ba9f23165d690b6cbdaa88cb0807278f7019848"
@@ -3144,13 +3119,6 @@ supports-preserve-symlinks-flag@^1.0.0:
31443119
resolved "https://registry.yarnpkg.com/supports-preserve-symlinks-flag/-/supports-preserve-symlinks-flag-1.0.0.tgz#6eda4bd344a3c94aea376d4cc31bc77311039e09"
31453120
integrity sha512-ot0WnXS9fgdkgIcePe6RHNk1WA8+muPa6cSjeR3V8K27q9BB1rTE3R1p7Hv0z1ZyAc8s6Vvv8DIyWf681MAt0w==
31463121

3147-
synckit@^0.11.7:
3148-
version "0.11.8"
3149-
resolved "https://registry.yarnpkg.com/synckit/-/synckit-0.11.8.tgz#b2aaae998a4ef47ded60773ad06e7cb821f55457"
3150-
integrity sha512-+XZ+r1XGIJGeQk3VvXhT6xx/VpbHsRzsTkGgF6E5RX9TTXD0118l87puaEBZ566FhqblC6U0d4XnubznJDm30A==
3151-
dependencies:
3152-
"@pkgr/core" "^0.2.4"
3153-
31543122
test-exclude@^6.0.0:
31553123
version "6.0.0"
31563124
resolved "https://registry.yarnpkg.com/test-exclude/-/test-exclude-6.0.0.tgz#04a8698661d805ea6fa293b6cb9e63ac044ef15e"

0 commit comments

Comments
 (0)