(PUP-10653) Remove dependency on win32/dir

For Puppet 7 we are dropping the `win32/dir` dependency as we only used
constants from it, which we replaced with environment variables (see:
puppetlabs/puppet#8314).

This would become breaking in bolt when it switches to Puppet 7 and the
win32 gems are no longer pulled.

For AIO bolt, the Puppet change won't break anything since bolt uses its
own runtime which still packages the win32 gems, but it would still be
an improvement in speed if the dependency is dropped.

The `win32/dir` gem also monkey patches some `Dir` methods, most notably
`glob` and `pwd` to use backslashes which end up causing more trouble as
Ruby uses `/` as the default separator for Windows.

Switch to using the `ALLUSERSPROFILE` environment variable instead of
the `Dir::COMMON_APPDATA` constant, and remove a `Dir.pwd` workaround.

!removal

  * **Remove dependency on win32/dir**
    ([PUP-10653](https://tickets.puppetlabs.com/browse/PUP-10653))

    Replace the usage of win32/dir constants with environment variables.

Author: GabrielNagy

lib/bolt/cli.rb

@@ -787,11 +787,7 @@ def generate_types
     # Initializes a specified directory as a Bolt project and installs any modules
     # specified by the user, along with their dependencies
     def initialize_project
-      # Dir.pwd will return backslashes on Windows, but Pathname always uses
-      # forward slashes to concatenate paths. This results in paths like
-      # C:\User\Administrator/modules, which fail module install. This ensure
-      # forward slashes in the cwd path.
-      dir = File.expand_path(Dir.pwd)
+      dir = Dir.pwd
       name = options[:object] || File.basename(dir)
       if name !~ Bolt::Module::MODULE_NAME_REGEX
         if options[:object]

lib/bolt/config.rb

@@ -74,11 +74,8 @@ def self.from_file(configfile, overrides = {})
     end
 
     def self.system_path
-      # Lazy-load expensive gem code
-      require 'win32/dir' if Bolt::Util.windows?
-
       if Bolt::Util.windows?
-        Pathname.new(File.join(Dir::COMMON_APPDATA, 'PuppetLabs', 'bolt', 'etc'))
+        Pathname.new(File.join(ENV['ALLUSERSPROFILE'], 'PuppetLabs', 'bolt', 'etc'))
       else
         Pathname.new(File.join('/etc', 'puppetlabs', 'bolt'))
       end

lib/bolt/puppetdb/config.rb

@@ -18,8 +18,7 @@ class Config
       end
 
       def self.default_windows_config
-        require 'win32/dir'
-        File.expand_path(File.join(Dir::COMMON_APPDATA, 'PuppetLabs/client-tools/puppetdb.conf'))
+        File.expand_path(File.join(ENV['ALLUSERSPROFILE'], 'PuppetLabs/client-tools/puppetdb.conf'))
       end
 
       def self.load_config(options, project_path = nil)