#543

--view=+COMMAND to wait for key press after COMMAND terminated, e.g. --view=+file to display file info with the `file` command and wait for a key press;
Wikipedia page "ANSI escape code" mentions that ESC ] P n rr gg bb may hang a terminal: TUI is updated to only support OSC code ESC ] 8 to display hyperlinks with option --hyperlink

Author: genivia-inc

src/query.cpp

@@ -2370,13 +2370,14 @@ void Query::view()
   }
 
   // if no viewer, then give up
-  if (flag_view == NULL || *flag_view == '\0')
+  if (flag_view == NULL || *flag_view == '\0' || (*flag_view == '+' && flag_view[1] == '\0'))
   {
     Screen::alert();
     return;
   }
 
-  std::string command(flag_view);
+  bool keypress = (*flag_view == '+');
+  std::string command(flag_view + keypress);
   int ref = select_ >= 0 ? select_ : row_;
   size_t line_number = 0;
 
@@ -2518,8 +2519,6 @@ void Query::view()
       bool changed = false;
 
       // track elapsed time: if the command terminates very quickly within 500ms, then let the user press a key
-      reflex::timer_type et;
-      reflex::timer_start(et);
 
       if (flag_stdin && filename == flag_label)
       {
@@ -2637,12 +2636,10 @@ void Query::view()
 
       if (ok)
       {
-        float ms = reflex::timer_elapsed(et);
-
 #ifdef OS_WIN
-        if (ms < 500 || strcmp(flag_view, "more") == 0)
+        if (keypress || strcmp(flag_view, "more") == 0)
 #else
-        if (ms < 500)
+        if (keypress)
 #endif
         {
           // command terminated very quickly within 500ms

src/screen.cpp

@@ -567,11 +567,11 @@ int Screen::put(int row, int col, const char *text, size_t size, int skip, int w
             break;
 
           default:
-            if (*text == '\033' && text + 1 < end && (text[1] == '[' || text[1] == ']'))
+            if (*text == '\033' && text + 2 < end && (text[1] == '[' || (text[1] == ']' && text[2] == '8')))
             {
-              if (text + 1 < end && text[1] == '[')
+              if (text[1] == '[')
               {
-                // CSI \e[... sequence
+                // ANSI CSI \e[... sequence
                 next = text;
                 next += 2;
                 while (next < end && (*next < 0x40 || *next > 0x7e))
@@ -586,7 +586,7 @@ int Screen::put(int row, int col, const char *text, size_t size, int skip, int w
               }
               else
               {
-                // OSC \e]...BEL|ST sequence
+                // ANSI OSC \e]8...BEL|ST sequence (hyperlink)
                 next = text;
                 next += 2;
                 while (next < end && *next != '\a' && (*next != '\033' || (next + 1 < end && next[1] != '\\')))
@@ -703,11 +703,11 @@ int Screen::put(int row, int col, const char *text, size_t size, int skip, int w
           break;
 
         default:
-          if (*ptr == '\033' && ptr + 1 < end && (ptr[1] == '[' || ptr[1] == ']'))
+          if (*ptr == '\033' && ptr + 2 < end && (ptr[1] == '[' || (ptr[1] == ']' && ptr[2] == '8')))
           {
             if (ptr[1] == '[')
             {
-              // CSI \e[... sequence
+              // ANSI CSI \e[... sequence
               if (mono)
                 put(text, ptr - text);
               ptr += 2;
@@ -728,7 +728,7 @@ int Screen::put(int row, int col, const char *text, size_t size, int skip, int w
             }
             else
             {
-              // OSC \e]...BEL|ST sequence
+              // ANSI OSC \e]8...BEL|ST sequence (hyperlink)
               if (mono)
                 put(text, ptr - text);
               ptr += 2;

src/ugrep.cpp

@@ -14689,8 +14689,9 @@ void help(std::ostream& out)
     -v, --invert-match\n\
             Selected lines are those not matching any of the specified\n\
             patterns.\n\
-    --view[=COMMAND]\n\
-            Use COMMAND to view/edit a file in -Q query TUI by pressing CTRL-Y.\n\
+    --view[=[+]COMMAND]\n\
+            Use COMMAND to view/edit a file in -Q query TUI by pressing CTRL-Y,\n\
+            +COMMAND waits for a key press after COMMAND terminated.\n\
     -W, --with-hex\n\
             Output binary matches in hexadecimal, leaving text matches alone.\n\
             This option is equivalent to the --binary-files=with-hex option.\n\