remove superfluous ferror() branch in close_file()

file read ferror() handling in close_file() after reporting when input closed does not require separate logic, the whole thing just ends; also avoids unlikely, but possible, timing issues in -z decompression thread synchronization

Author: genivia-inc

src/ugrep.cpp

@@ -3824,48 +3824,8 @@ struct Grep {
   {
     // check if the input has no error conditions, but do not check stdin which is nonblocking and handled differently
     if (file_in != NULL && file_in != stdin && file_in != Static::source && ferror(file_in))
-    {
       warning("cannot read", pathname);
 
-#ifdef HAVE_LIBZ
-#ifdef WITH_DECOMPRESSION_THREAD
-
-      if (flag_decompress)
-      {
-        // close the input FILE* and its underlying pipe previously created with pipe() and fdopen()
-        if (input.file() != NULL)
-        {
-          // close and unassign input, i.e. input.file() == NULL, also closes pipe_fd[0] per fdopen()
-          fclose(input.file());
-          input.clear();
-        }
-
-        zthread.cancel();
-      }
-
-#else
-
-      if (stream != NULL)
-      {
-        delete stream;
-        stream = NULL;
-      }
-
-#endif
-#endif
-
-      // close the current input file
-      if (file_in != NULL && file_in != stdin && file_in != Static::source)
-      {
-        fclose(file_in);
-        file_in = NULL;
-      }
-
-      input.clear();
-
-      return false;
-    }
-
 #ifdef HAVE_LIBZ
 #ifdef WITH_DECOMPRESSION_THREAD