Changes per review

Author: qqmyers

doc/release-notes/11281-ExternalSearch.md

@@ -8,4 +8,4 @@ An additional /api/search/engines endpoint allows discovery of the engines insta
 In addition to two trivial example engines designed for testing, Dataverse ships with two search engine classes that support calling an enternally-hosted search service (via HTTP GET or POST).
 These classes rely on the internal solr search to perform access-control and to format the final results, simplifying development of such an external engine.
 
-Details about the new functionality are described in 
+Details about the new functionality are described in https://guides.dataverse.org/en/latest/developers/search-services.html

doc/sphinx-guides/source/developers/search-services.rst

@@ -28,7 +28,7 @@ The ``SearchService`` interface is the core of the configurable search services.
        default void setSolrSearchService(SearchService solrSearchService);
    }
 
-The interface allows you to provide a service name and dsiplay name, and to respond to the same search parameters that are normally sent to the solr search engine.
+The interface allows you to provide a service name and display name, and to respond to the same search parameters that are normally sent to the solr search engine.
 
 The setSolrSearchService method is used by Dataverse to give your class a reference to the SolrSearchService, allowing your class to perform solr queries as needed. (See the ExternalSearchServices for an example.)
 

src/main/java/edu/harvard/iq/dataverse/search/GetExternalSearchServiceBean.java

@@ -56,14 +56,14 @@ public SolrQueryResponse search(DataverseRequest dataverseRequest, List<Datavers
                 filterQueries, addHighlights, addFacets, onlyDataRelatedToMe, retrieveEntities, geoPoint, geoRadius);
 
         // Send GET request to external service
-        Client client = ClientBuilder.newClient();
-        Response response = client.target(externalSearchUrl).queryParam("params", queryParams)
-                .request(MediaType.APPLICATION_JSON).get();
+        try (Client client = ClientBuilder.newClient()) {
+            Response response = client.target(externalSearchUrl).queryParam("params", queryParams)
+                    .request(MediaType.APPLICATION_JSON).get();
+
+            if (response.getStatus() != 200) {
+                throw new SearchException("External search service returned status " + response.getStatus(), null);
+            }
 
-        if (response.getStatus() != 200) {
-            throw new SearchException("External search service returned status " + response.getStatus(), null);
-        }
-        try {
             // Parse response and process results
             String responseString = response.readEntity(String.class);
             logger.finest("External search returned: " + responseString);