fix: refresh shared indexer after knowledge base updates

Author: Helweg

src/tools/index.ts

@@ -1,7 +1,7 @@
 import { tool, type ToolDefinition } from "@opencode-ai/plugin";
 
+import { parseConfig, type ParsedCodebaseIndexConfig } from "../config/schema.js";
 import { Indexer } from "../indexer/index.js";
-import { ParsedCodebaseIndexConfig } from "../config/schema.js";
 import { formatCostEstimate } from "../utils/cost.js";
 import type { LogLevel } from "../config/schema.js";
 import type { LogEntry } from "../utils/logger.js";
@@ -30,6 +30,14 @@ export function initializeTools(projectRoot: string, config: ParsedCodebaseIndex
   sharedIndexer = new Indexer(projectRoot, config);
 }
 
+function refreshIndexerFromConfig(): void {
+  if (!sharedProjectRoot) {
+    throw new Error("Codebase index tools not initialized. Plugin may not be loaded correctly.");
+  }
+
+  sharedIndexer = new Indexer(sharedProjectRoot, parseConfig(loadConfig()));
+}
+
 function getIndexer(): Indexer {
   if (!sharedIndexer) {
     throw new Error("Codebase index tools not initialized. Plugin may not be loaded correctly.");
@@ -372,6 +380,7 @@ export const add_knowledge_base: ToolDefinition = tool({
     knowledgeBases.push(resolvedPath);
     config.knowledgeBases = knowledgeBases;
     saveConfig(config);
+    refreshIndexerFromConfig();
 
     let result = `${resolvedPath}\n`;
     result += `Total knowledge bases: ${knowledgeBases.length}\n`;
@@ -458,6 +467,7 @@ export const remove_knowledge_base: ToolDefinition = tool({
     const removed = knowledgeBases.splice(index, 1)[0];
     config.knowledgeBases = knowledgeBases;
     saveConfig(config);
+    refreshIndexerFromConfig();
 
     let result = `Removed: ${removed}\n\n`;
     result += `Remaining knowledge bases: ${knowledgeBases.length}\n`;

tests/tools-knowledge-bases.test.ts

@@ -0,0 +1,116 @@
+import * as fs from "fs";
+import * as os from "os";
+import * as path from "path";
+
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+
+const { indexerInstances, MockIndexer } = vi.hoisted(() => {
+  const indexerInstances: Array<{ projectRoot: string; config: Record<string, unknown> }> = [];
+
+  class MockIndexer {
+    public readonly projectRoot: string;
+    public readonly config: Record<string, unknown>;
+
+    public constructor(projectRoot: string, config: Record<string, unknown>) {
+      this.projectRoot = projectRoot;
+      this.config = config;
+      indexerInstances.push({ projectRoot, config });
+    }
+
+    public estimateCost = vi.fn().mockResolvedValue({
+      filesCount: 0,
+      totalSizeBytes: 0,
+      estimatedChunks: 0,
+      estimatedTokens: 0,
+      estimatedCost: 0,
+      isFree: true,
+      provider: "ollama",
+      model: "nomic-embed-text",
+    });
+
+    public clearIndex = vi.fn().mockResolvedValue(undefined);
+    public index = vi.fn().mockResolvedValue({
+      totalFiles: 0,
+      totalChunks: 0,
+      indexedChunks: 0,
+      failedChunks: 0,
+      tokensUsed: 0,
+      durationMs: 0,
+      existingChunks: 0,
+      removedChunks: 0,
+      skippedFiles: [],
+      parseFailures: [],
+    });
+
+    public getStatus = vi.fn().mockResolvedValue({
+      indexed: true,
+      vectorCount: 0,
+      provider: "ollama",
+      model: "nomic-embed-text",
+      indexPath: "/tmp/index",
+      currentBranch: "main",
+      baseBranch: "main",
+    });
+
+    public healthCheck = vi.fn().mockResolvedValue({
+      removed: 0,
+      gcOrphanEmbeddings: 0,
+      gcOrphanChunks: 0,
+      gcOrphanSymbols: 0,
+      gcOrphanCallEdges: 0,
+      filePaths: [],
+    });
+
+    public getLogger = vi.fn().mockReturnValue({
+      isEnabled: vi.fn().mockReturnValue(false),
+      isMetricsEnabled: vi.fn().mockReturnValue(false),
+      getLogs: vi.fn().mockReturnValue([]),
+      getLogsByCategory: vi.fn().mockReturnValue([]),
+      getLogsByLevel: vi.fn().mockReturnValue([]),
+      formatMetrics: vi.fn().mockReturnValue(""),
+    });
+  }
+
+  return { indexerInstances, MockIndexer };
+});
+
+vi.mock("../src/indexer/index.js", () => ({
+  Indexer: MockIndexer,
+}));
+
+import { parseConfig } from "../src/config/schema.js";
+import { add_knowledge_base, initializeTools, remove_knowledge_base } from "../src/tools/index.js";
+
+describe("knowledge base tool config refresh", () => {
+  let tempDir: string;
+  let kbDir: string;
+
+  beforeEach(() => {
+    indexerInstances.length = 0;
+    tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "kb-tools-test-"));
+    kbDir = fs.mkdtempSync(path.join(os.tmpdir(), "kb-source-"));
+    initializeTools(tempDir, parseConfig({ indexing: { watchFiles: false } }));
+  });
+
+  afterEach(() => {
+    fs.rmSync(tempDir, { recursive: true, force: true });
+    fs.rmSync(kbDir, { recursive: true, force: true });
+  });
+
+  it("rebuilds the shared indexer after adding a knowledge base", async () => {
+    await add_knowledge_base.execute({ path: kbDir });
+
+    expect(indexerInstances).toHaveLength(2);
+    expect(indexerInstances[1]?.projectRoot).toBe(tempDir);
+    expect(indexerInstances[1]?.config.knowledgeBases).toEqual([path.normalize(kbDir)]);
+  });
+
+  it("rebuilds the shared indexer after removing a knowledge base", async () => {
+    await add_knowledge_base.execute({ path: kbDir });
+    await remove_knowledge_base.execute({ path: kbDir });
+
+    expect(indexerInstances).toHaveLength(3);
+    expect(indexerInstances[2]?.projectRoot).toBe(tempDir);
+    expect(indexerInstances[2]?.config.knowledgeBases).toEqual([]);
+  });
+});