test: add integration tests for health check and auto-refresh behavior in GatewayService

Signed-off-by: Lang-Akshay <akshay.shinde26@ibm.com>

Author: Lang-Akshay

tests/unit/mcpgateway/services/test_gateway_hot_cold_integration.py

@@ -10,6 +10,7 @@
 
 # Standard
 import time
+from datetime import datetime, timedelta
 from unittest.mock import AsyncMock, MagicMock, patch
 
 # Third-Party
@@ -591,3 +592,165 @@ async def _mark_side_effect(url, poll_type):
 
             # Exception from mark_poll_completed(tool_discovery) must not propagate
             await gateway_service._check_single_gateway_health(mock_gateway, user_email="test@example.com")
+
+
+def _make_http_client_context_manager():
+    """Build the async context manager chain used by tests that go through get_isolated_http_client."""
+    mock_response = MagicMock()
+    mock_response.status_code = 200
+    mock_response.raise_for_status = MagicMock()
+    mock_stream_cm = MagicMock()
+    mock_stream_cm.__aenter__ = AsyncMock(return_value=mock_response)
+    mock_stream_cm.__aexit__ = AsyncMock(return_value=False)
+    mock_http_client = MagicMock()
+    mock_http_client.stream = MagicMock(return_value=mock_stream_cm)
+    mock_client_cm = MagicMock()
+    mock_client_cm.__aenter__ = AsyncMock(return_value=mock_http_client)
+    mock_client_cm.__aexit__ = AsyncMock(return_value=False)
+    return mock_client_cm
+
+
+class TestBranchSpecificMissingLines:
+    """Tests that cover lines identified as missing in this branch's changes."""
+
+    # ------------------------------------------------------------------
+    # Line 3590: last_refresh.replace(tzinfo=timezone.utc) — naive datetime
+    # inside the new `should_auto_refresh` gate added by this branch.
+    # ------------------------------------------------------------------
+
+    @pytest.mark.asyncio
+    async def test_auto_refresh_naive_last_refresh_at_triggers_tzinfo_fix(self, gateway_service_with_classification, monkeypatch):
+        """Naive datetime in last_refresh_at gets UTC tzinfo applied before comparison (line 3590)."""
+        monkeypatch.setattr("mcpgateway.services.gateway_service.settings.auto_refresh_servers", True)
+        monkeypatch.setattr("mcpgateway.services.gateway_service.settings.gateway_auto_refresh_interval", 300)
+
+        gateway_service, mock_classification = gateway_service_with_classification
+        # Disable classification so should_auto_refresh=True via the unconditional else branch
+        gateway_service._classification_service = None
+
+        mock_gateway = _make_mock_gateway(url="http://test-server:8000", name="test-gateway")
+        # Naive datetime (no tzinfo), old enough that time_since_refresh > 300s
+        mock_gateway.last_refresh_at = datetime.utcnow() - timedelta(hours=2)
+        mock_gateway.refresh_interval_seconds = None
+
+        mock_refresh = AsyncMock(return_value={"added": 0, "updated": 0, "removed": 0})
+
+        with (
+            patch.object(gateway_service, "_refresh_gateway_tools_resources_prompts", mock_refresh),
+            patch("mcpgateway.services.gateway_service.fresh_db_session") as mock_fresh_db,
+            patch("mcpgateway.services.gateway_service.get_isolated_http_client") as mock_get_client,
+        ):
+            mock_session = MagicMock()
+            mock_fresh_db.return_value.__enter__.return_value = mock_session
+            mock_session.execute.return_value.scalar_one_or_none.return_value = mock_gateway
+            mock_session.commit = MagicMock()
+            mock_get_client.return_value = _make_http_client_context_manager()
+
+            # Should not raise; tzinfo fix is applied and refresh proceeds
+            await gateway_service._check_single_gateway_health(mock_gateway, user_email="test@example.com")
+
+        # Refresh must have been called (naive datetime was handled correctly)
+        mock_refresh.assert_awaited_once()
+
+    @pytest.mark.asyncio
+    async def test_auto_refresh_naive_last_refresh_at_within_interval_skips_refresh(self, gateway_service_with_classification, monkeypatch):
+        """Naive datetime recent enough to skip refresh is still handled without error (line 3590 + throttle)."""
+        monkeypatch.setattr("mcpgateway.services.gateway_service.settings.auto_refresh_servers", True)
+        monkeypatch.setattr("mcpgateway.services.gateway_service.settings.gateway_auto_refresh_interval", 3600)
+
+        gateway_service, mock_classification = gateway_service_with_classification
+        gateway_service._classification_service = None
+
+        mock_gateway = _make_mock_gateway(url="http://test-server:8000", name="test-gateway")
+        # Naive datetime, refreshed 30 seconds ago (within 3600s interval)
+        mock_gateway.last_refresh_at = datetime.utcnow() - timedelta(seconds=30)
+        mock_gateway.refresh_interval_seconds = None
+
+        mock_refresh = AsyncMock(return_value={"added": 0, "updated": 0, "removed": 0})
+
+        with (
+            patch.object(gateway_service, "_refresh_gateway_tools_resources_prompts", mock_refresh),
+            patch("mcpgateway.services.gateway_service.fresh_db_session") as mock_fresh_db,
+            patch("mcpgateway.services.gateway_service.get_isolated_http_client") as mock_get_client,
+        ):
+            mock_session = MagicMock()
+            mock_fresh_db.return_value.__enter__.return_value = mock_session
+            mock_session.execute.return_value.scalar_one_or_none.return_value = mock_gateway
+            mock_session.commit = MagicMock()
+            mock_get_client.return_value = _make_http_client_context_manager()
+
+            await gateway_service._check_single_gateway_health(mock_gateway, user_email="test@example.com")
+
+        # Not due for refresh yet
+        mock_refresh.assert_not_awaited()
+
+    # ------------------------------------------------------------------
+    # Lines 3344-3345: decode_auth exception on query_param auth type
+    # Inside _check_single_gateway_health, modified by this branch.
+    # ------------------------------------------------------------------
+
+    @pytest.mark.asyncio
+    async def test_health_check_query_param_decryption_failure_proceeds_fail_open(self, gateway_service_with_classification):
+        """Health check proceeds when query-param auth decryption raises an exception (lines 3344-3345)."""
+        gateway_service, mock_classification = gateway_service_with_classification
+        mock_classification.should_poll_server = AsyncMock(return_value=True)
+        mock_classification.mark_poll_completed = AsyncMock()
+
+        mock_gateway = _make_mock_gateway(url="http://test-server:8000", name="test-gateway")
+        mock_gateway.auth_type = "query_param"
+        mock_gateway.auth_query_params = {"api_key": "badly_encrypted_value"}
+
+        with (
+            patch("mcpgateway.services.gateway_service.decode_auth", side_effect=Exception("Decryption failed")),
+            patch("mcpgateway.services.gateway_service.fresh_db_session") as mock_fresh_db,
+            patch("mcpgateway.services.gateway_service.get_isolated_http_client") as mock_get_client,
+        ):
+            mock_session = MagicMock()
+            mock_fresh_db.return_value.__enter__.return_value = mock_session
+            mock_session.execute.return_value.scalar_one_or_none.return_value = mock_gateway
+            mock_session.commit = MagicMock()
+            mock_get_client.return_value = _make_http_client_context_manager()
+
+            # Must not raise; decryption failure is silently logged (line 3344-3345)
+            await gateway_service._check_single_gateway_health(mock_gateway, user_email="test@example.com")
+
+        # Health check still executed (get_isolated_http_client was called)
+        mock_get_client.assert_called_once()
+
+    # ------------------------------------------------------------------
+    # Line 3398: ssl_context = None (else branch) for https URL with no CA cert
+    # Inside _check_single_gateway_health, modified by this branch.
+    # ------------------------------------------------------------------
+
+    @pytest.mark.asyncio
+    async def test_health_check_https_url_no_ca_cert_ssl_context_none(self, gateway_service_with_classification):
+        """ssl_context is None for https URL with no CA certificate (line 3398 else branch)."""
+        gateway_service, mock_classification = gateway_service_with_classification
+        mock_classification.should_poll_server = AsyncMock(return_value=True)
+        mock_classification.mark_poll_completed = AsyncMock()
+
+        # https URL + no CA certificate → falls into the else: ssl_context = None branch (line 3398)
+        mock_gateway = _make_mock_gateway(url="https://secure-server:8443", name="test-gateway")
+        # ca_certificate is None by default in _make_mock_gateway — no valid cert, no ssl override
+
+        ssl_context_captured = {}
+
+        original_get_isolated = __import__("mcpgateway.services.gateway_service", fromlist=["get_isolated_http_client"])
+
+        def capture_ssl_context(*args, **kwargs):
+            ssl_context_captured["verify"] = kwargs.get("verify")
+            return _make_http_client_context_manager()
+
+        with (
+            patch("mcpgateway.services.gateway_service.fresh_db_session") as mock_fresh_db,
+            patch("mcpgateway.services.gateway_service.get_isolated_http_client", side_effect=capture_ssl_context),
+        ):
+            mock_session = MagicMock()
+            mock_fresh_db.return_value.__enter__.return_value = mock_session
+            mock_session.execute.return_value.scalar_one_or_none.return_value = mock_gateway
+            mock_session.commit = MagicMock()
+
+            await gateway_service._check_single_gateway_health(mock_gateway, user_email="test@example.com")
+
+        # ssl_context should be None (the else branch at line 3398)
+        assert ssl_context_captured.get("verify") is None