Skip to content

Commit 8f55abe

Browse files
calculus-askcalculus-ask
committed
add ADFS SSO unit and integration tests
Signed-off-by: calculus-ask <a.santhana.k@gmail.com>
1 parent 583b65c commit 8f55abe

5 files changed

Lines changed: 59 additions & 62 deletions

File tree

‎.secrets.baseline‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"files": "package-lock.json|Cargo.lock|^.secrets.baseline$|scripts/sign_image.sh|scripts/zap|sonar-project.properties|^/Users/brian/dev/github.ibm.com/contextforge-org/sps-pipeline-config/.secrets.baseline$|^./.secrets.baseline$",
44
"lines": null
55
},
6-
"generated_at": "2026-03-30T09:04:40Z",
6+
"generated_at": "2026-03-30T18:16:29Z",
77
"plugins_used": [
88
{
99
"name": "AWSKeyDetector"
@@ -164,15 +164,15 @@
164164
"hashed_secret": "ca45060a53fd8a255d1a83ee8d2f025283ccc66e",
165165
"is_secret": false,
166166
"is_verified": false,
167-
"line_number": 1116,
167+
"line_number": 1119,
168168
"type": "Secret Keyword",
169169
"verified_result": null
170170
},
171171
{
172172
"hashed_secret": "910fbf00f58e9bcb095ea26a75cc1d9a3355e671",
173173
"is_secret": false,
174174
"is_verified": false,
175-
"line_number": 1165,
175+
"line_number": 1179,
176176
"type": "Secret Keyword",
177177
"verified_result": null
178178
}
@@ -780,63 +780,63 @@
780780
"hashed_secret": "25ab86bed149ca6ca9c1c0d5db7c9a91388ddeab",
781781
"is_secret": false,
782782
"is_verified": false,
783-
"line_number": 942,
783+
"line_number": 943,
784784
"type": "Basic Auth Credentials",
785785
"verified_result": null
786786
},
787787
{
788788
"hashed_secret": "d08f88df745fa7950b104e4a707a31cfce7b5841",
789789
"is_secret": false,
790790
"is_verified": false,
791-
"line_number": 1042,
791+
"line_number": 1043,
792792
"type": "Secret Keyword",
793793
"verified_result": null
794794
},
795795
{
796796
"hashed_secret": "7288edd0fc3ffcbe93a0cf06e3568e28521687bc",
797797
"is_secret": false,
798798
"is_verified": false,
799-
"line_number": 1045,
799+
"line_number": 1046,
800800
"type": "Secret Keyword",
801801
"verified_result": null
802802
},
803803
{
804804
"hashed_secret": "8674c9b302d20800e4ab3808f139704d8641a6e3",
805805
"is_secret": false,
806806
"is_verified": false,
807-
"line_number": 1211,
807+
"line_number": 1212,
808808
"type": "Secret Keyword",
809809
"verified_result": null
810810
},
811811
{
812812
"hashed_secret": "cff0d14e4337fa8bdb68dfa906f04b0df6fad72f",
813813
"is_secret": false,
814814
"is_verified": false,
815-
"line_number": 1250,
815+
"line_number": 1251,
816816
"type": "Secret Keyword",
817817
"verified_result": null
818818
},
819819
{
820820
"hashed_secret": "f865b53623b121fd34ee5426c792e5c33af8c227",
821821
"is_secret": false,
822822
"is_verified": false,
823-
"line_number": 1298,
823+
"line_number": 1299,
824824
"type": "Secret Keyword",
825825
"verified_result": null
826826
},
827827
{
828828
"hashed_secret": "acde39840735314af1300688b6c2324ea89770a3",
829829
"is_secret": false,
830830
"is_verified": false,
831-
"line_number": 1393,
831+
"line_number": 1394,
832832
"type": "Secret Keyword",
833833
"verified_result": null
834834
},
835835
{
836836
"hashed_secret": "fa9beb99e4029ad5a6615399e7bbae21356086b3",
837837
"is_secret": false,
838838
"is_verified": false,
839-
"line_number": 1741,
839+
"line_number": 1742,
840840
"type": "Secret Keyword",
841841
"verified_result": null
842842
}
@@ -5742,7 +5742,7 @@
57425742
"hashed_secret": "ff37a98a9963d347e9749a5c1b3936a4a245a6ff",
57435743
"is_secret": false,
57445744
"is_verified": false,
5745-
"line_number": 2052,
5745+
"line_number": 2075,
57465746
"type": "Secret Keyword",
57475747
"verified_result": null
57485748
}
@@ -6074,7 +6074,7 @@
60746074
"hashed_secret": "920a25ef686c4f7ca6ad23dd109d3ad653161832",
60756075
"is_secret": false,
60766076
"is_verified": false,
6077-
"line_number": 747,
6077+
"line_number": 780,
60786078
"type": "Secret Keyword",
60796079
"verified_result": null
60806080
}
@@ -6402,39 +6402,39 @@
64026402
"hashed_secret": "920a25ef686c4f7ca6ad23dd109d3ad653161832",
64036403
"is_secret": false,
64046404
"is_verified": false,
6405-
"line_number": 42,
6405+
"line_number": 43,
64066406
"type": "Secret Keyword",
64076407
"verified_result": null
64086408
},
64096409
{
64106410
"hashed_secret": "b44bf05d644c15c4d84f78771de011e3cce924c0",
64116411
"is_secret": false,
64126412
"is_verified": false,
6413-
"line_number": 59,
6413+
"line_number": 60,
64146414
"type": "Secret Keyword",
64156415
"verified_result": null
64166416
},
64176417
{
64186418
"hashed_secret": "999a3419d9959d3c39b11dcc67d79c7888b4b765",
64196419
"is_secret": false,
64206420
"is_verified": false,
6421-
"line_number": 71,
6421+
"line_number": 72,
64226422
"type": "Secret Keyword",
64236423
"verified_result": null
64246424
},
64256425
{
64266426
"hashed_secret": "bacac952b5cb942687d38a9eda6531d570f88b22",
64276427
"is_secret": false,
64286428
"is_verified": false,
6429-
"line_number": 84,
6429+
"line_number": 85,
64306430
"type": "Secret Keyword",
64316431
"verified_result": null
64326432
},
64336433
{
64346434
"hashed_secret": "cd1ecfcd67c8b85800a483d77e550d36727e8925",
64356435
"is_secret": false,
64366436
"is_verified": false,
6437-
"line_number": 98,
6437+
"line_number": 99,
64386438
"type": "Secret Keyword",
64396439
"verified_result": null
64406440
}
@@ -9926,23 +9926,23 @@
99269926
"hashed_secret": "920a25ef686c4f7ca6ad23dd109d3ad653161832",
99279927
"is_secret": false,
99289928
"is_verified": false,
9929-
"line_number": 167,
9929+
"line_number": 174,
99309930
"type": "Secret Keyword",
99319931
"verified_result": null
99329932
},
99339933
{
99349934
"hashed_secret": "3340ad734a33028b9498d58dc8b49e9c02157b19",
99359935
"is_secret": false,
99369936
"is_verified": false,
9937-
"line_number": 188,
9937+
"line_number": 195,
99389938
"type": "Secret Keyword",
99399939
"verified_result": null
99409940
},
99419941
{
99429942
"hashed_secret": "ec09a041656818107eb855453ffbf7327d3bbc9d",
99439943
"is_secret": false,
99449944
"is_verified": false,
9945-
"line_number": 325,
9945+
"line_number": 332,
99469946
"type": "Secret Keyword",
99479947
"verified_result": null
99489948
}
@@ -11040,15 +11040,15 @@
1104011040
"hashed_secret": "fe1bae27cb7c1fb823f496f286e78f1d2ae87734",
1104111041
"is_secret": false,
1104211042
"is_verified": false,
11043-
"line_number": 330,
11043+
"line_number": 370,
1104411044
"type": "Secret Keyword",
1104511045
"verified_result": null
1104611046
},
1104711047
{
1104811048
"hashed_secret": "945db841c03e42eef2f3d0a4ff310e2f3b3e59ec",
1104911049
"is_secret": false,
1105011050
"is_verified": false,
11051-
"line_number": 414,
11051+
"line_number": 454,
1105211052
"type": "Secret Keyword",
1105311053
"verified_result": null
1105411054
}

‎docs/docs/manage/sso-adfs-tutorial.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ SSO_ADFS_ENABLED=true
1919

2020
# ADFS Configuration
2121
SSO_ADFS_CLIENT_ID=your-adfs-client-id
22-
SSO_ADFS_CLIENT_SECRET=your-adfs-client-secret
22+
SSO_ADFS_CLIENT_SECRET=your-adfs-client-secret # pragma: allowlist secret
2323
SSO_ADFS_AUTHORIZATION_URL=https://adfs.ds.example.net/adfs/oauth2/authorize/
2424
SSO_ADFS_TOKEN_URL=https://adfs.ds.example.net/adfs/oauth2/token/
2525
SSO_ADFS_ISSUER=https://adfs.ds.example.net/adfs
@@ -222,7 +222,7 @@ Expected response:
222222

223223
**Cause**: The ID token is malformed or not present in the token response.
224224

225-
**Solution**:
225+
**Solution**:
226226
1. Verify that ADFS is configured to return an ID token
227227
2. Check that the `openid` scope is included in the authorization request
228228
3. Review ADFS logs for any token generation errors

‎tests/integration/test_sso_adfs_integration.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ def cleanup_sso_data(test_db: Session):
4343
test_db.query(SSOProvider).delete()
4444
test_db.query(EmailUser).delete()
4545
test_db.commit()
46-
46+
4747
yield
48-
48+
4949
# Clean up after test
5050
test_db.query(SSOAuthSession).delete()
5151
test_db.query(SSOProvider).delete()

0 commit comments

Comments
 (0)
⚡