Skip to content

Commit 6279ca9

Browse files
committed
Added: explanatory comment to port mapping of dev_dataverse and removed redundant param
1 parent 151f980 commit 6279ca9

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

dev-env/docker-compose-dev.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@ services:
7272
-Ddataverse.files.s3.connection-pool-size=2048
7373
-Ddataverse.files.s3.custom-endpoint-region=us-east-1
7474
-Ddataverse.files.s3.custom-endpoint-url=https://s3.us-east-1.amazonaws.com
75-
expose:
76-
- '8080'
77-
# TODO: The port has been opened for the redirection to /oauth2/callback.xhtml after a JSF OIDC login. We may prefer to change this to use the proxy.
75+
# We publish the port on the host machine instead of just exposing it within the network, so that the browser can access the URLs of images generated by Dataverse (http://localhost:8080...).
76+
# This is necessary because the dev_nginx proxy is placed on top of the Dataverse service, making those URLs unreachable unless this port is exposed.
77+
# This workaround is only necessary and intended for the local dev environment and will not be used in the remote environment, where we use a production DNS.
7878
ports:
7979
- '8080:8080'
8080
networks:

0 commit comments

Comments
 (0)