Skip to content

Commit 68a42a3

Browse files
committed
fix: add changelog and fix wording of tests
1 parent c5df514 commit 68a42a3

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ This changelog follows the principles of [Keep a Changelog](https://keepachangel
3838
- Dataset versions: (1) file changes should be `Access: Restricted` instead of `isResticted: true/false`; (2) logic of View Detail button. (#879)
3939
- File versions: (1) logic of linking to a file version; (2)If file not included, show text information "File not included in this version.". (#879)
4040
- Dataset page publish flow now avoids rendering duplicate tab sets by making tabs skeleton and tabs content mutually exclusive.
41+
- Fixed custom terms navigation url while publishing a datsaet.
4142

4243
### Removed
4344

tests/component/sections/dataset/dataset-publish/PublishDatasetModal.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ describe('PublishDatasetModal', () => {
242242
.and('include', `/collections/${parentCollection.id}`)
243243
})
244244

245-
it('Displays custom terms when license is undefined', () => {
245+
it('displays custom terms when license is undefined', () => {
246246
const parentCollection = UpwardHierarchyNodeMother.createCollection({ isReleased: false })
247247

248248
mountPublishDatasetModal({
@@ -279,7 +279,7 @@ describe('PublishDatasetModal', () => {
279279
cy.findByRole('link', { name: 'CC0 1.0' }).should('exist')
280280
})
281281

282-
it('opens the terms tab URL without duplicating the base path when Custom Dataset Terms link is clicked', () => {
282+
it('opens the terms tab URL when Custom Dataset Terms link is clicked', () => {
283283
const windowOpenStub = cy.stub().as('windowOpen')
284284
cy.window().then((win) => {
285285
cy.stub(win, 'open').callsFake(windowOpenStub)

0 commit comments

Comments
 (0)