Skip to content

Commit 71b939a

Browse files
committed
fix: lint error
1 parent 0799fd7 commit 71b939a

4 files changed

Lines changed: 9 additions & 13 deletions

File tree

packages/design-system/src/lib/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export { NavbarDropdown } from './components/navbar/navbar-dropdown/NavbarDropdo
1212
export { ThemeProvider, useTheme } from './components/theme/ThemeProvider'
1313
export { Breadcrumb } from './components/breadcrumb/Breadcrumb'
1414
export { Alert } from './components/alert/Alert'
15+
export type { AlertVariant } from './components/alert/AlertVariant'
1516
export { Tabs } from './components/tabs/Tabs'
1617
export { Accordion } from './components/accordion/Accordion'
1718
export { ButtonGroup } from './components/button-group/ButtonGroup'

src/alert/domain/models/Alert.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { AlertVariant } from '@iqss/dataverse-design-system/dist/components/alert/AlertVariant'
1+
import { type AlertVariant } from '@iqss/dataverse-design-system'
22

33
export enum AlertMessageKey {
44
DRAFT_VERSION = 'draftVersion',

tests/component/sections/dataset/dataset-versions/useGetDatasetVersionDiff.spec.tsx

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,9 @@ const datasetRepository: DatasetRepository = {} as DatasetRepository
99

1010
const datasetVersionDiff: DatasetVersionDiff = DatasetVersionDiffMother.create()
1111

12-
const datasetVersionDiffMock = {
13-
differences: datasetVersionDiff,
14-
error: 'There was an error getting the dataset version differences',
15-
isLoading: false
16-
}
17-
1812
describe('useGetDatasetVersionDiff', () => {
1913
it('should return dataset version differences correctly', async () => {
20-
datasetRepository.getVersionDiff = cy.stub().resolves(datasetVersionDiffMock)
14+
datasetRepository.getVersionDiff = cy.stub().resolves(datasetVersionDiff)
2115
const { result } = renderHook(() =>
2216
useGetDatasetVersionDiff({
2317
datasetRepository,
@@ -32,7 +26,7 @@ describe('useGetDatasetVersionDiff', () => {
3226
return expect(result.current.differences).to.deep.equal(undefined)
3327
})
3428

35-
void waitFor(() => {
29+
await waitFor(() => {
3630
expect(result.current.isLoading).to.deep.equal(false)
3731
return expect(result.current.differences).to.deep.equal(datasetVersionDiff)
3832
})
@@ -56,8 +50,10 @@ describe('useGetDatasetVersionDiff', () => {
5650
return expect(result.current.differences).to.deep.equal(undefined)
5751
})
5852

59-
expect(result.current.isLoading).to.deep.equal(false)
60-
expect(result.current.error).to.deep.equal(error.message)
53+
await waitFor(() => {
54+
expect(result.current.isLoading).to.deep.equal(false)
55+
expect(result.current.error).to.deep.equal(error.message)
56+
})
6157
})
6258

6359
it('should return a generic error message for non-Error exceptions', async () => {
@@ -78,7 +74,7 @@ describe('useGetDatasetVersionDiff', () => {
7874
return expect(result.current.differences).to.deep.equal(undefined)
7975
})
8076

81-
await act(() => {
77+
await waitFor(() => {
8278
expect(result.current.isLoading).to.deep.equal(false)
8379
return expect(result.current.error).to.deep.equal(
8480
'Something went wrong getting the information from the dataset version differences. Try again later.'

tests/component/sections/layout/footer/Footer.spec.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ describe('Footer component', () => {
2525

2626
it('should call dataverseInfoRepository.getVersion on mount', () => {
2727
const dataverseInfoRepository = new DataverseInfoMockRepository()
28-
const getVersionSpy = sandbox.spy(dataverseInfoRepository, 'getVersion')
2928

3029
cy.customMount(<Footer dataverseInfoRepository={dataverseInfoRepository} />)
3130

0 commit comments

Comments
 (0)