fix: reverse some unneccessary changes

Author: ChengShi-1

dev-env/nginx.conf

@@ -68,7 +68,7 @@ http {
       proxy_set_header    X-Forwarded-Port   $server_port;
     }
 
-    # Route for modern frontend (update path to match VITE_BASE_PATH)
+    # Route for SPA frontend
     location /modern {
       proxy_pass http://frontend:5173;
       proxy_http_version 1.1;

dev-env/shib-dev-env/nginx/nginx.conf

@@ -71,7 +71,7 @@ http {
       proxy_set_header    X-Forwarded-Port   $server_port;
     }
 
-    # Route for modern frontend (update path to match VITE_BASE_PATH)
+    # Route for SPA frontend
     location /modern {
       proxy_pass http://frontend:5173;
       proxy_http_version 1.1;

src/sections/edit-collection-featured-items/featured-items-form/FeaturedItemsFormHelper.ts

@@ -43,7 +43,7 @@ export class FeaturedItemsFormHelper {
           itemId: id,
           type,
           dvObjectIdentifier,
-          dvObjectUrl: this.transformDvObjectTypeAndIdentifierToURL(type, dvObjectIdentifier)
+          dvObjectUrl: this.transformDvObjectTypeAndIdentifierToSpaURL(type, dvObjectIdentifier)
         }
 
         return dvObjectFeaturedItemFormFieldData
@@ -213,13 +213,13 @@ export class FeaturedItemsFormHelper {
   }
 
   /**
-   * @description This method transforms the type and identifier of a Dataverse object into a URL for the modern frontend of Dataverse.
+   * @description This method transforms the type and identifier of a Dataverse object into a URL for the Modern version of Dataverse.
    * @param type - The type of the Dataverse object (Collection, Dataset, or File).
    * @param identifier - The identifier of the Dataverse object (e.g., alias for Collection, persistent ID for Dataset, or file ID for File).
    * @returns A string representing the URL for the specified Dataverse object.
    */
 
-  static transformDvObjectTypeAndIdentifierToURL = (
+  static transformDvObjectTypeAndIdentifierToSpaURL = (
     type: FeaturedItemType.COLLECTION | FeaturedItemType.DATASET | FeaturedItemType.FILE,
     identifier: string
   ): string => {

tests/component/sections/edit-featured-items/FeaturedItemsFormHelper.spec.ts

@@ -374,7 +374,7 @@ describe('FeaturedItemsFormHelper', () => {
   describe('transformDvObjectTypeAndIdentifierToURL', () => {
     it('should return collection page URL when type is collection', () => {
       const identifier = 'sample-collection-id'
-      const result = FeaturedItemsFormHelper.transformDvObjectTypeAndIdentifierToURL(
+      const result = FeaturedItemsFormHelper.transformDvObjectTypeAndIdentifierToSpaURL(
         FeaturedItemType.COLLECTION,
         identifier
       )
@@ -384,7 +384,7 @@ describe('FeaturedItemsFormHelper', () => {
 
     it('should return dataset page URL when type is dataset', () => {
       const identifier = 'doi:10.5072/FK2/ABC123'
-      const result = FeaturedItemsFormHelper.transformDvObjectTypeAndIdentifierToURL(
+      const result = FeaturedItemsFormHelper.transformDvObjectTypeAndIdentifierToSpaURL(
         FeaturedItemType.DATASET,
         identifier
       )
@@ -394,7 +394,7 @@ describe('FeaturedItemsFormHelper', () => {
 
     it('should return file page URL when type is file', () => {
       const identifier = '44'
-      const result = FeaturedItemsFormHelper.transformDvObjectTypeAndIdentifierToURL(
+      const result = FeaturedItemsFormHelper.transformDvObjectTypeAndIdentifierToSpaURL(
         FeaturedItemType.FILE,
         identifier
       )
@@ -405,7 +405,7 @@ describe('FeaturedItemsFormHelper', () => {
     it('should return # when type does not match any known type', () => {
       const identifier = 'unknown-id'
 
-      const result = FeaturedItemsFormHelper.transformDvObjectTypeAndIdentifierToURL(
+      const result = FeaturedItemsFormHelper.transformDvObjectTypeAndIdentifierToSpaURL(
         'unknown-type' as FeaturedItemType.COLLECTION, // This cast is to simulate an unknown type and prevent TypeScript to complain
         identifier
       )