fix(fixtures): ensure timestamps are explicitly set for required DvObject properties in fixture builders (Dataset and DataFile)

Author: poikilotherm

src/test/java/edu/harvard/iq/dataverse/util/testing/fixtures/BuildContext.java

@@ -1,5 +1,9 @@
 package edu.harvard.iq.dataverse.util.testing.fixtures;
 
+import java.sql.Timestamp;
+import java.time.Instant;
+import java.util.Date;
+
 /**
  * Immutable build context shared across a single fixture build.
  *
@@ -11,6 +15,16 @@
  * @param sequence deterministic sequence number for the fixture instance
  */
 public record BuildContext(
-        long sequence
+        long sequence,
+        Instant now
 ) {
+
+    Timestamp getTimestamp() {
+        return Timestamp.from(now);
+    }
+    
+    Date getDate() {
+        return Date.from(now);
+    }
+
 }

src/test/java/edu/harvard/iq/dataverse/util/testing/fixtures/DatasetFixtureBuilder.java

@@ -17,6 +17,7 @@
 import edu.harvard.iq.dataverse.util.testing.recipes.VariableSetRecipe;
 import edu.harvard.iq.dataverse.util.testing.recipes.VersionRecipe;
 
+import java.time.Instant;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Objects;
@@ -109,7 +110,7 @@ public DatasetFixture build() {
         Objects.requireNonNull(populator, "populator must not be null");
 
         // One context per build, so populators can use deterministic information about this fixture instance.
-        BuildContext context = new BuildContext(SEQUENCE.getAndIncrement());
+        BuildContext context = new BuildContext(SEQUENCE.getAndIncrement(), Instant.now());
 
         // Create the top-level dataset and its current version, then wire them.
         Dataset dataset = createEmptyDataset(context);

src/test/java/edu/harvard/iq/dataverse/util/testing/fixtures/MinimalPopulator.java

@@ -15,7 +15,6 @@
 import edu.harvard.iq.dataverse.util.testing.recipes.VariableSetBuildContext;
 
 import java.util.ArrayList;
-import java.util.Date;
 import java.util.HashSet;
 
 public final class MinimalPopulator implements FixturePopulator {
@@ -33,6 +32,10 @@ public void populateDataset(Dataset dataset, BuildContext context) {
         dataset.setIdentifier("fixture-dataset-" + context.sequence());
         dataset.setStorageIdentifier("fixture-storage-" + context.sequence());
         dataset.setDatasetType(new DatasetType());
+        
+        // necessary as DvObject says "not nullable"
+        dataset.setCreateDate(context.getTimestamp());
+        dataset.setModificationTime(context.getTimestamp());
     }
 
     /**
@@ -43,13 +46,12 @@ public void populateDataset(Dataset dataset, BuildContext context) {
      */
     @Override
     public void populateDatasetVersion(DatasetVersion version, BuildContext context) {
-        Date now = new Date();
         version.setVersionNumber(1L);
         version.setMinorVersionNumber(0L);
         version.setVersionState(DatasetVersion.VersionState.DRAFT);
         version.setVersionNote("fixture-version");
-        version.setCreateTime(now);
-        version.setLastUpdateTime(now);
+        version.setCreateTime(context.getDate());
+        version.setLastUpdateTime(context.getDate());
 
         // TermsOfUseAndAccess and DatasetVersion are mutually linked via a OneToOne.
         // The validator reads datasetVersion from the terms object, so both sides
@@ -90,6 +92,10 @@ public void populateDataFile(DataFile dataFile, FileBuildContext fileBuildContex
         dataFile.setDataTables(new ArrayList<>());
         dataFile.setFileMetadatas(new ArrayList<>());
         dataFile.setTags(new ArrayList<>());
+        
+        // necessary as DvObject says "not nullable"
+        dataFile.setCreateDate(context.getTimestamp());
+        dataFile.setModificationTime(context.getTimestamp());
     }
 
     /**