#11710 add test for without perms

Author: sekmiller

src/main/java/edu/harvard/iq/dataverse/engine/command/impl/GetLinkingDataverseListCommand.java

@@ -77,7 +77,7 @@ public List<Dataverse> execute(CommandContext ctxt) throws CommandException {
         } else {
             permToCheck = Permission.LinkDataverse;
         }
-        //dependin on the already linked boolean the command will return a list of Dataverses available for linking
+        //depending on the already linked boolean the command will return a list of Dataverses available for linking
         // or a list of dataverses to which the object has already been linked - for the unlink function
         if (!alreadyLinked) {
             dataversesForLinking = ctxt.permissions().findPermittedCollections(getRequest(), authUser, permToCheck, searchParam);
@@ -98,7 +98,6 @@ public List<Dataverse> execute(CommandContext ctxt) throws CommandException {
                     }
                     return dataversesAlreadyLinkedCanUnlink;
                 }
-                //this.permissionService.requestOn(req, res).has(Permission.LinkDataverse)
             } else {
                 dataversesAlreadyLinked = ctxt.dvLinking().findLinkingDataverses(dvObject.getId(), searchParam);
                 for (Dataverse dv : dataversesAlreadyLinked) {

src/test/java/edu/harvard/iq/dataverse/api/DataversesIT.java

@@ -844,6 +844,14 @@ public void testGetLinkableDataverses(){
                 .statusCode(OK.getStatusCode())
                 .body("data.size()", equalTo(1));  
 
+        //if you ask for already linked you should get one  unless you don't have perms     
+        getLinkableDataverses = UtilIT.getLinkableDataverses("dataset", datasetPersistentId, apiTokenThree, dataverseAliasForLinking, true);
+        
+        getLinkableDataverses.prettyPrint();
+                getLinkableDataverses.then().assertThat()
+                .statusCode(OK.getStatusCode())
+                .body("data.size()", equalTo(0));          
+                
         //if you ask for already linked you should get one unless there's a bad search terms     
         getLinkableDataverses = UtilIT.getLinkableDataverses("dataset", datasetPersistentId, apiToken, "QQQBatmanSymbol", true);