Added Dataset.getGlobalIdForFileStorage for direct upload URLs that support legacy lowercase DOIs (#12268)

* Added Dataset.getGlobalIdForFileStorage which gives the global ID in the original casing, so it does not uppercase
DOIs. It is called when generating the upload URLs for direct upload instead of using dataset.getGlobalId().asString().
The latter gave a mismatch between the complete URL and the actual object keys in object store when DOIs contained
lowercase letters (which is possible when they were created before Dataverse started enforcing uppercase DOIs).

* release note

* Update release notes for S3 direct upload fix

Clarified the issue addressed with S3 direct upload regarding PID authority and alternative identifiers.

* Renamed Dataset.getGlobalIdForFileStorage() to Dataset.getGlobalIdForFileStorageAsString() to clarify that it does not return a GlobalId object

---------

Co-authored-by: qqmyers <jim.myers@computer.org>

Author: janvanmansum

doc/release-notes/12268-direct-upload-support-legacy-lowercase-dois.md

@@ -0,0 +1 @@
+Fixed a problem with S3 direct upload to datasets which using lower- or mixed-case PID authority/identifier in the database and to datasets using an alternative identifier for file storage.

src/main/java/edu/harvard/iq/dataverse/Dataset.java

@@ -662,6 +662,10 @@ public String getIdentifierForFileStorage(){
         return retVal;         
     }
 
+    public String getGlobalIdForFileStorageAsString() {
+        return getProtocolForFileStorage() + ":" + getAuthorityForFileStorage() + "/" + getIdentifierForFileStorage();
+    }
+
     public String getNextMajorVersionString() {
         // Never need to get the next major version for harvested studies.
         if (isHarvested()) {

src/main/java/edu/harvard/iq/dataverse/EditDatafilesPage.java

@@ -1706,7 +1706,7 @@ public void requestDirectUploadUrls() {
         String storageIdentifier = null;
         try {
             storageIdentifier = FileUtil.getStorageIdentifierFromLocation(s3io.getStorageLocation());
-            urls = s3io.generateTemporaryS3UploadUrls(dataset.getGlobalId().asString(), storageIdentifier, fileSize);
+            urls = s3io.generateTemporaryS3UploadUrls(dataset.getGlobalIdForFileStorageAsString(), storageIdentifier, fileSize);
 
         } catch (IOException io) {
             logger.warning(io.getMessage());

src/main/java/edu/harvard/iq/dataverse/api/Datasets.java

@@ -2798,7 +2798,7 @@ public Response getMPUploadUrls(@Context ContainerRequestContext crc, @PathParam
             String storageIdentifier = null;
             try {
                 storageIdentifier = FileUtil.getStorageIdentifierFromLocation(s3io.getStorageLocation());
-                response = s3io.generateTemporaryS3UploadUrls(dataset.getGlobalId().asString(), storageIdentifier, fileSize);
+                response = s3io.generateTemporaryS3UploadUrls(dataset.getGlobalIdForFileStorageAsString(), storageIdentifier, fileSize);
 
             } catch (IOException io) {
                 logger.warning(io.getMessage());