Guard against NPE in BagGenerator (#12246)

janvanmansum · web-flow · commit da0ed7781e4e · 2026-03-27T09:08:03.000-04:00
* Guard against NPE

* Release note
diff --git a/doc/release-notes/12246-guard-npe-bag-generator.md b/doc/release-notes/12246-guard-npe-bag-generator.md
@@ -0,0 +1 @@
+Fixed a problem in the BagPack generator, which caused the export to fail for datasets with multiple Contact Points, of which some had no name while others did.
diff --git a/src/main/java/edu/harvard/iq/dataverse/util/bagit/BagGenerator.java b/src/main/java/edu/harvard/iq/dataverse/util/bagit/BagGenerator.java
@@ -938,7 +938,7 @@ private String generateInfoFile() {
                         info.append(CRLF);
 
                     } else {
-                        if (contactNameTerm != null) {
+                        if (contactNameTerm != null && ((JsonObject) person).has(contactNameTerm.getLabel())) {
                             info.append(multilineWrap(CONTACT_NAME + ((JsonObject) person).get(contactNameTerm.getLabel()).getAsString()));
                             info.append(CRLF);
                         }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fixed a problem in the BagPack generator, which caused the export to fail for datasets with multiple Contact Points, of which some had no name while others did.`
Original file line number	Diff line number	Diff line change
`@@ -938,7 +938,7 @@ private String generateInfoFile() {`
`938`	`938`	`info.append(CRLF);`
`939`	`939`
`940`	`940`	`} else {`
`941`		`- if (contactNameTerm != null) {`
	`941`	`+ if (contactNameTerm != null && ((JsonObject) person).has(contactNameTerm.getLabel())) {`
`942`	`942`	`info.append(multilineWrap(CONTACT_NAME + ((JsonObject) person).get(contactNameTerm.getLabel()).getAsString()));`
`943`	`943`	`info.append(CRLF);`
`944`	`944`	`}`