Skip to content

Commit db88104

Browse files
authored
Merge pull request #12072 from IQSS/11206-refresh-landing-page-after-delete
11206 refresh landing page after delete
2 parents bbe4846 + 178520e commit db88104

3 files changed

Lines changed: 24 additions & 0 deletions

File tree

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
## Bug Fix ##
2+
3+
JSF UI will no longer display the deleted Dataset/Dataverse. A 1 second delay in the UI page redirect gives Solr time to re-index and remove the deleted object.
4+
5+
See:
6+
- [#11206](https://github.com/IQSS/dataverse/issues/11206)

src/main/java/edu/harvard/iq/dataverse/DatasetPage.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3127,10 +3127,19 @@ public String deleteDataset() {
31273127
if (deleteCommandSuccess) {
31283128
datafileService.finalizeFileDeletes(deleteStorageLocations);
31293129
JsfHelper.addSuccessMessage(BundleUtil.getStringFromBundle("dataset.message.deleteSuccess"));
3130+
solrDelay();
31303131
}
31313132

31323133
return "/dataverse.xhtml?alias=" + dataset.getOwner().getAlias() + "&faces-redirect=true";
31333134
}
3135+
// delay 1 second so solr has time to update the indexes. Without the delay the UI will continue to show the deleted dataset
3136+
private void solrDelay() {
3137+
try {
3138+
Thread.sleep(1000L);
3139+
} catch (InterruptedException e) {
3140+
throw new RuntimeException(e);
3141+
}
3142+
}
31343143

31353144
public String editFileMetadata(){
31363145
// If there are no files selected, return an empty string - which

src/main/java/edu/harvard/iq/dataverse/DataversePage.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -920,12 +920,21 @@ public String deleteDataverse() {
920920
try {
921921
commandEngine.submit(cmd);
922922
JsfHelper.addSuccessMessage(BundleUtil.getStringFromBundle("dataverse.delete.success"));
923+
solrDelay();
923924
} catch (Exception ex) {
924925
logger.log(Level.SEVERE, "Unexpected Exception calling delete dataverse command", ex);
925926
JsfHelper.addErrorMessage(BundleUtil.getStringFromBundle("dataverse.delete.failure"));
926927
}
927928
return "/dataverse.xhtml?alias=" + dataverse.getOwner().getAlias() + "&faces-redirect=true";
928929
}
930+
// delay 1 second so solr has time to update the indexes. Without the delay the UI will continue to show the deleted dataverse
931+
private void solrDelay() {
932+
try {
933+
Thread.sleep(1000L);
934+
} catch (InterruptedException e) {
935+
throw new RuntimeException(e);
936+
}
937+
}
929938

930939
public String getMetadataBlockPreview(MetadataBlock mdb, int numberOfItems) {
931940
/// for beta, we will just preview the first n fields

0 commit comments

Comments
 (0)