Skip to content

Commit ddd3e94

Browse files
authored
Merge pull request #12173 from GlobalDataverseCommunityConsortium/MyDataTestFix
Fix another MyData test
2 parents f20e75a + 80c1c63 commit ddd3e94

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

src/test/java/edu/harvard/iq/dataverse/api/DataRetrieverApiIT.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,15 @@ public static void setUpClass() {
3232
}
3333

3434
@Test
35-
public void testRetrieveMyDataAsJsonString() {
35+
public void testRetrieveMyDataAsJsonString() throws InterruptedException {
3636
// Call with bad API token
3737
ArrayList<Long> emptyRoleIdsList = new ArrayList<>();
3838
Response badApiTokenResponse = UtilIT.retrieveMyDataAsJsonString("bad-token", "dummy-user-identifier", emptyRoleIdsList);
3939
badApiTokenResponse.then().assertThat().body("status", equalTo(ApiConstants.STATUS_ERROR)).body("message", equalTo(ApiKeyAuthMechanism.RESPONSE_MESSAGE_BAD_API_KEY)).statusCode(UNAUTHORIZED.getStatusCode());
4040

4141
// Call as superuser with invalid user identifier
4242
Response createUserResponse = UtilIT.createRandomUser();
43-
Response makeSuperUserResponse = UtilIT.makeSuperUser(UtilIT.getUsernameFromResponse(createUserResponse));
43+
Response makeSuperUserResponse = UtilIT.setSuperuserStatus(UtilIT.getUsernameFromResponse(createUserResponse), true);
4444
assertEquals(OK.getStatusCode(), makeSuperUserResponse.getStatusCode());
4545
String superUserApiToken = UtilIT.getApiTokenFromResponse(createUserResponse);
4646

@@ -87,6 +87,7 @@ public void testRetrieveMyDataAsJsonString() {
8787
// Call as normal user with one valid dataverse role and one dataverse result
8888
UtilIT.grantRoleOnDataverse(dataverseAlias, DataverseRole.DS_CONTRIBUTOR.toString(),
8989
"@" + normalUserUsername, superUserApiToken);
90+
Thread.sleep(4000);
9091
Response oneDataverseResponse = UtilIT.retrieveMyDataAsJsonString(normalUserApiToken, "", new ArrayList<>(Arrays.asList(5L)));
9192
oneDataverseResponse.prettyPrint();
9293

@@ -118,7 +119,7 @@ public void testRetrieveMyDataCollections() throws InterruptedException {
118119
Response retrieveMyCollectionListResponse;
119120
// Create Superuser
120121
Response createUserResponse = UtilIT.createRandomUser();
121-
Response makeSuperUserResponse = UtilIT.makeSuperUser(UtilIT.getUsernameFromResponse(createUserResponse));
122+
Response makeSuperUserResponse = UtilIT.setSuperuserStatus(UtilIT.getUsernameFromResponse(createUserResponse), true);
122123
assertEquals(OK.getStatusCode(), makeSuperUserResponse.getStatusCode());
123124
String superUserUsername = UtilIT.getUsernameFromResponse(createUserResponse);
124125
String superUserApiToken = UtilIT.getApiTokenFromResponse(createUserResponse);
@@ -476,6 +477,8 @@ public void testRetrieveMyDataWithCollections() {
476477

477478
UtilIT.publishDatasetViaNativeApi(datasetId, "major", apiToken).then().assertThat().statusCode(OK.getStatusCode());
478479

480+
UtilIT.sleepForReindex(datasetPid, apiToken, 5);
481+
479482
// Test that the Dataverse collection that the dataset was created in is returned
480483
Response myDataResponse = UtilIT.retrieveMyDataAsJsonString(apiToken, "", new ArrayList<>(Arrays.asList(6L)), "&show_collections=true");
481484
myDataResponse.prettyPrint();

0 commit comments

Comments
 (0)