fix role assign, add logging for revoke debugging

Author: qqmyers

src/main/java/edu/harvard/iq/dataverse/ManagePermissionsPage.java

@@ -151,6 +151,7 @@ public RoleAssignment getSelectedRoleAssignment() {
     }
 
     public void setSelectedRoleAssignment(RoleAssignment selectedRoleAssignment) {
+        logger.info("Selecting ra: " + selectedRoleAssignment.toString());
         this.selectedRoleAssignment = selectedRoleAssignment;
     }
 
@@ -187,6 +188,11 @@ public List<RoleAssignmentRow> initRoleAssignments() {
     }
 
     public void removeRoleAssignment() {
+        if(selectedRoleAssignment != null) {
+          logger.info("revoking " + selectedRoleAssignment.toString());
+        } else {
+            logger.info("No RA to revoke");
+        }
         revokeRole(selectedRoleAssignment);
 
         if (dvObject instanceof Dataverse) {

src/main/webapp/permissions-manage.xhtml

@@ -105,7 +105,8 @@
                                         <p:commandLink id="userGroupsAdd" styleClass="btn btn-default"
                                                        actionListener="#{managePermissionsPage.initAssigneeDialog}"
                                                        update="userGroupDialog roleAssignmentHistory"
-                                                       oncomplete="PF('userGroupsForm').show();handleResizeDialog('userGroupDialog');">
+                                                       oncomplete="PF('userGroupsForm').show();handleResizeDialog('userGroupDialog');"
+                                                       process='@this'>
                                             <span class="glyphicon glyphicon-user"/> #{bundle['dataverse.permissions.usersOrGroups.assignBtn']}
                                         </p:commandLink>
                                     </div>
@@ -133,8 +134,9 @@
                                                 </h:outputFormat>
                                                 <p:commandLink styleClass="btn btn-default"
                                                                rendered="#{managePermissionsPage.dvObject eq roleAssignment.definitionPoint}"
-                                                               onclick="PF('confirmation').show()">
-                                                    <f:setPropertyActionListener value="#{roleAssignment.roleAssignment}" target="#{managePermissionsPage.selectedRoleAssignment}" />
+                                                               process="assignedRoles"
+                                                               oncomplete="PF('confirmation').show()">
+                                                    <f:setPropertyActionListener value="#{roleAssignment.roleAssignment}" target="#{managePermissionsPage.selectedRoleAssignment}"/>
                                                     <span class="glyphicon glyphicon-remove"/> #{bundle['dataverse.permissions.usersOrGroups.removeBtn']}
                                                 </p:commandLink>
                                             </p:column>

src/main/webapp/roles-assign.xhtml

@@ -91,7 +91,8 @@
                 <p:commandButton styleClass="btn btn-default" value="#{bundle.saveChanges}"
                                update="assignRoleContent assignedRoles roleAssignmentHistory @([id$=Messages])"
                                actionListener="#{managePermissionsPage.assignRole}" 
-                               oncomplete="if (args &amp;&amp; !args.validationFailed) PF('userGroupsForm').hide();">
+                               oncomplete="if (args &amp;&amp; !args.validationFailed) PF('userGroupsForm').hide();"
+                               process="userGroupNameAssign assignRoleRadios @this">
                     <f:param name="DO_ASSIGN_VALIDATION" value="true"/>
                 </p:commandButton>
                 <button type="button" class="btn btn-link" onclick="PF('userGroupsForm').hide()">