feat: add "string" type for metadata fields#11321
Merged
ofahimIQSS merged 5 commits intoIQSS:developfrom Mar 31, 2025
Merged
Conversation
stevenwinship
approved these changes
Mar 12, 2025
Contributor
|
Could you please update this PR with the latest from Develop? Need pom.xml to show 6.6. Thanks! |
Member
|
@vera or @johannes-darms will have to do it. I tried but I don't have permission. 😅 |
Contributor
Author
|
Done! Apparently, the option "Allow edits by maintainers" isn't available for PRs made from forks owned by organizations, so that's why you couldn't push @pdurbin ... Too bad (but a request to change that is open here: https://github.com/orgs/community/discussions/5634) |
Member
|
@vera thanks, I bookmarked that request. Thanks also for merging the latest from develop! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does / why we need it:
See #11147
Which issue(s) this PR closes:
Special notes for your reviewer:
/
Suggestions on how to test this:
Load a metadata block TSV that defines a field with type "string"
example: https://gist.github.com/vera/fc39e7b0bb0e9da7dc24a41c680f6d59
curl http://localhost:8080/api/admin/datasetfield/load -H "Content-type: text/tab-separated-values" -X POST --upload-file stringtest.tsvActivate metadata block
curl curl -H "X-Dataverse-key:$API_TOKEN" -X POST -H "Content-type:application/json" -d "[\"citation\", \"stringTest\"]" http://localhost:8080/api/dataverses/:root/metadatablocksUpdate Solr schema
curl "http://localhost:8080/api/admin/index/solr/schema" | ./update-fields.sh schema.xmldocker cp schema.xml solr-1:/var/solr/data/collection1/conf/schema.xmlcurl "http://localhost:8983/solr/admin/cores?action=RELOAD&core=collection1"Confirm that the updated Solr schema contains a new field with type "string"
Create a new dataset via the UI (or API)
Verify the string value correctly ends up in Solr and can be seen on the dataset page
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
/
Is there a release notes update needed for this change?:
Yes, I think that would be good. I've added a release note as part of this PR.
Additional documentation:
/