Skip to content

remove unused show_my_data Search API parameter#11375

Merged
ofahimIQSS merged 2 commits intodevelopfrom
11287-show_my_data
Apr 3, 2025
Merged

remove unused show_my_data Search API parameter#11375
ofahimIQSS merged 2 commits intodevelopfrom
11287-show_my_data

Conversation

@pdurbin
Copy link
Copy Markdown
Member

@pdurbin pdurbin commented Mar 26, 2025

What this PR does / why we need it:

Having this unused parameter lying around is confusing.

Which issue(s) this PR closes:

Special notes for your reviewer:

In the issue I linked to some old related commits and issues if you're interested.

Suggestions on how to test this:

  • Make sure API tests pass.
  • You could try passing the parameter. It shouldn't change anything.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Yes, included.

Additional documentation:

https://dataverse-guide--11375.org.readthedocs.build/en/11375/api/changelog.html

@pdurbin pdurbin moved this to Ready for Review ⏩ in IQSS Dataverse Project Mar 26, 2025
@github-actions github-actions Bot added FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) FY25 Sprint 19 FY25 Sprint 19 (2025-03-12 - 2025-03-26) Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA These changes are required for the Dataverse SPA SPA.Q1.8 Type: Feature a feature request labels Mar 26, 2025
@pdurbin pdurbin requested a review from GPortas March 26, 2025 16:56
@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11287-show-my-data
ghcr.io/gdcc/configbaker:11287-show-my-data

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 26, 2025

Coverage Status

coverage: 22.729% (+0.001%) from 22.728%
when pulling 7a0a3a1 on 11287-show_my_data
into c4f3d76 on develop.

@GPortas GPortas self-assigned this Mar 26, 2025
@GPortas GPortas moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Mar 26, 2025
@pdurbin pdurbin requested a review from sekmiller March 26, 2025 20:00
Copy link
Copy Markdown
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdurbin The PR makes sense within the scope of removing the unused parameter, but it doesn't close issue #11287. We still need a decision on which APIs to use for implementing the My Data page in the SPA and should create new issues if necessary to extend the API.

@pdurbin
Copy link
Copy Markdown
Member Author

pdurbin commented Mar 27, 2025

@GPortas ok, I marked this PR as only related to the issue and put that issue back on the board for continued analysis. Thanks.

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Mar 27, 2025
@cmbz cmbz added the FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) label Mar 30, 2025
@ofahimIQSS ofahimIQSS self-assigned this Mar 31, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Mar 31, 2025
@ofahimIQSS
Copy link
Copy Markdown
Contributor

merging PR looks good from my end

@ofahimIQSS ofahimIQSS merged commit c687d18 into develop Apr 3, 2025
17 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Apr 3, 2025
@ofahimIQSS ofahimIQSS removed their assignment Apr 3, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Apr 3, 2025
@pdurbin pdurbin added this to the 6.7 milestone Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) FY25 Sprint 19 FY25 Sprint 19 (2025-03-12 - 2025-03-26) FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA.Q1.8 SPA These changes are required for the Dataverse SPA Type: Feature a feature request

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

6 participants