Skip to content

add replace to update category api#11403

Merged
ofahimIQSS merged 3 commits intodevelopfrom
11401-update-categories-with-replace
Apr 9, 2025
Merged

add replace to update category api#11403
ofahimIQSS merged 3 commits intodevelopfrom
11401-update-categories-with-replace

Conversation

@stevenwinship
Copy link
Copy Markdown
Contributor

What this PR does / why we need it: Update Categories API needs replace param (same as tabularTags) to allow for deletion of existing categories.

Which issue(s) this PR closes:#11401

Special notes for your reviewer: Matches tabularTags code changes in #11292

Suggestions on how to test this: See FilesIt test. Make API calls with and without replace parameter

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: Included

Additional documentation:

@stevenwinship stevenwinship self-assigned this Apr 7, 2025
@github-actions github-actions Bot added FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) Size: 3 A percentage of a sprint. 2.1 hours. SPA These changes are required for the Dataverse SPA SPA.Q1.6 File Page: File Edit Options labels Apr 7, 2025
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Apr 7, 2025
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2025

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11401-update-categories-with-replace
ghcr.io/gdcc/configbaker:11401-update-categories-with-replace

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 7, 2025

Coverage Status

coverage: 22.728% (-0.001%) from 22.729%
when pulling 29190cd on 11401-update-categories-with-replace
into c687d18 on develop.

@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Apr 7, 2025
@stevenwinship stevenwinship removed their assignment Apr 7, 2025
@sekmiller sekmiller self-assigned this Apr 8, 2025
@sekmiller sekmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 8, 2025
Copy link
Copy Markdown
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ready for QA

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Apr 8, 2025
@sekmiller sekmiller removed their assignment Apr 8, 2025
@ofahimIQSS ofahimIQSS self-assigned this Apr 9, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Apr 9, 2025
@GPortas GPortas added the SPA.Q2 Not related to any specific Q2 feature label Apr 9, 2025
@ofahimIQSS
Copy link
Copy Markdown
Contributor

Tests are passing, no issues found. Merging PR

@ofahimIQSS ofahimIQSS merged commit 7aa6235 into develop Apr 9, 2025
25 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Apr 9, 2025
@ofahimIQSS ofahimIQSS deleted the 11401-update-categories-with-replace branch April 9, 2025 17:19
@ofahimIQSS ofahimIQSS removed their assignment Apr 9, 2025
@pdurbin pdurbin added this to the 6.7 milestone Apr 9, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1.6 File Page: File Edit Options SPA.Q2 Not related to any specific Q2 feature SPA These changes are required for the Dataverse SPA

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

File edit categories: allow categories replacement

7 participants