Skip to content

Commit 6e4880d

Browse files
jeremydvossJWinermaSplunk
authored andcommitted
OTEL_PYTHON_LOG_LEVEL
1 parent a28dd95 commit 6e4880d

3 files changed

Lines changed: 17 additions & 30 deletions

File tree

opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
OTEL_EXPORTER_OTLP_TRACES_PROTOCOL,
5555
OTEL_PYTHON_TRACER_CONFIGURATOR,
5656
OTEL_PYTHON_LOG_FORMAT,
57-
OTEL_PYTHON_LOG_HANDLER_LEVEL,
57+
OTEL_PYTHON_LOG_LEVEL,
5858
OTEL_TRACES_SAMPLER,
5959
OTEL_TRACES_SAMPLER_ARG,
6060
OTEL_PYTHON_LOG_LEVEL,
@@ -105,7 +105,7 @@
105105

106106
_OTEL_SAMPLER_ENTRY_POINT_GROUP = "opentelemetry_traces_sampler"
107107

108-
_OTEL_PYTHON_LOG_HANDLER_LEVEL_BY_NAME = {
108+
_OTEL_PYTHON_LOG_LEVEL_BY_NAME = {
109109
"notset": logging.NOTSET,
110110
"debug": logging.DEBUG,
111111
"info": logging.INFO,
@@ -180,8 +180,8 @@ def _get_id_generator() -> str:
180180
return environ.get(OTEL_PYTHON_ID_GENERATOR, _DEFAULT_ID_GENERATOR)
181181

182182
def _get_log_level() -> int:
183-
return _OTEL_PYTHON_LOG_HANDLER_LEVEL_BY_NAME.get(
184-
environ.get(OTEL_PYTHON_LOG_HANDLER_LEVEL, "notset").lower().strip(),
183+
return _OTEL_PYTHON_LOG_LEVEL_BY_NAME.get(
184+
environ.get(OTEL_PYTHON_LOG_LEVEL, "notset").lower().strip(),
185185
logging.NOTSET,
186186
)
187187

@@ -350,7 +350,7 @@ def _init_logging(
350350
level=logging.NOTSET, logger_provider=provider
351351
)
352352
# Log level
353-
if OTEL_PYTHON_LOG_HANDLER_LEVEL in environ:
353+
if OTEL_PYTHON_LOG_LEVEL in environ:
354354
handler.setLevel(_get_log_level())
355355
# Log format
356356
if OTEL_PYTHON_LOG_FORMAT in environ:

opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,11 @@
6262
Default: "logging.BASIC_FORMAT"
6363
"""
6464

65-
OTEL_PYTHON_LOG_HANDLER_LEVEL = "OTEL_PYTHON_LOG_HANDLER_LEVEL"
65+
OTEL_PYTHON_LOG_LEVEL = "OTEL_PYTHON_LOG_LEVEL"
6666
"""
67-
.. envvar:: OTEL_PYTHON_LOG_HANDLER_LEVEL
67+
.. envvar:: OTEL_PYTHON_LOG_LEVEL
6868
69-
The :envvar:`OTEL_PYTHON_LOG_HANDLER_LEVEL` environment variable sets the log level for the OpenTelemetry LoggingHandler
69+
The :envvar:`OTEL_PYTHON_LOG_LEVEL` environment variable sets the log level for the OpenTelemetry LoggingHandler
7070
Default: "logging.NOTSET"
7171
"""
7272

opentelemetry-sdk/tests/test_configurator.py

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -871,7 +871,7 @@ def test_logging_init_exporter_level_under(self, log_level_mock):
871871
environ,
872872
{
873873
"OTEL_RESOURCE_ATTRIBUTES": "service.name=otlp-service",
874-
"OTEL_PYTHON_LOG_HANDLER_LEVEL": "CUSTOM_LOG_LEVEL",
874+
"OTEL_PYTHON_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
875875
},
876876
clear=True,
877877
)
@@ -908,6 +908,7 @@ def test_logging_init_exporter_level_under(self, log_level_mock):
908908
environ,
909909
{
910910
"OTEL_RESOURCE_ATTRIBUTES": "service.name=otlp-service",
911+
"OTEL_PYTHON_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
911912
"OTEL_PYTHON_LOG_HANDLER_LEVEL": "CUSTOM_LOG_LEVEL",
912913
"OTEL_PYTHON_LOG_FORMAT": CUSTOM_LOG_FORMAT,
913914
},
@@ -983,45 +984,31 @@ def test_logging_init_exporter_without_handler_setup(self):
983984
def test_otel_log_level_by_name_default(self):
984985
self.assertEqual(_get_log_level(), NOTSET)
985986

986-
@patch.dict(
987-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": "NOTSET "}, clear=True
988-
)
987+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": "NOTSET "}, clear=True)
989988
def test_otel_log_level_by_name_notset(self):
990989
self.assertEqual(_get_log_level(), NOTSET)
991990

992-
@patch.dict(
993-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": " DeBug "}, clear=True
994-
)
991+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " DeBug "}, clear=True)
995992
def test_otel_log_level_by_name_debug(self):
996993
self.assertEqual(_get_log_level(), DEBUG)
997994

998-
@patch.dict(
999-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": " info "}, clear=True
1000-
)
995+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " info "}, clear=True)
1001996
def test_otel_log_level_by_name_info(self):
1002997
self.assertEqual(_get_log_level(), INFO)
1003998

1004-
@patch.dict(
1005-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": " warn"}, clear=True
1006-
)
999+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " warn"}, clear=True)
10071000
def test_otel_log_level_by_name_warn(self):
10081001
self.assertEqual(_get_log_level(), WARNING)
10091002

1010-
@patch.dict(
1011-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": " warnING "}, clear=True
1012-
)
1003+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " warnING "}, clear=True)
10131004
def test_otel_log_level_by_name_warning(self):
10141005
self.assertEqual(_get_log_level(), WARNING)
10151006

1016-
@patch.dict(
1017-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": " eRroR"}, clear=True
1018-
)
1007+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " eRroR"}, clear=True)
10191008
def test_otel_log_level_by_name_error(self):
10201009
self.assertEqual(_get_log_level(), ERROR)
10211010

1022-
@patch.dict(
1023-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": "foobar"}, clear=True
1024-
)
1011+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": "foobar"}, clear=True)
10251012
def test_otel_log_level_by_name_invalid(self):
10261013
self.assertEqual(_get_log_level(), NOTSET)
10271014

0 commit comments

Comments
 (0)