Skip to content

Commit 6c3d7c0

Browse files
committed
perf(ci): revert download_test_data to use runner rather than container
When the cache hits (which is pretty much always), it's much faster to just use the runner, rather than wait for the container image pull. The job will be about 4 seconds, rather than 1-3 minutes.
1 parent 8e1aedb commit 6c3d7c0

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ jobs:
4545

4646
download_test_data:
4747
runs-on: ubuntu-latest
48-
container:
49-
image: codecr.jlab.org/hallb/clas12/container-forge/base:latest
50-
options: --user root
48+
# NOTE: using Ubuntu runner, rather than a `container-forge` image, since it's much faster for cache hits
5149
strategy:
5250
fail-fast: true
5351
matrix:
@@ -64,6 +62,12 @@ jobs:
6462
key: validation_files_${{ matrix.type }}
6563
path: validation_files.tar.zst
6664
lookup-only: true
65+
- name: install dependencies
66+
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
67+
run: |
68+
sudo apt -y update
69+
sudo apt -y upgrade
70+
sudo apt -y install xrootd-client
6771
- name: download
6872
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
6973
run: xrdcp ${{ env.xrootd_file }} ./

0 commit comments

Comments
 (0)