Skip to content

Commit b3ac275

Browse files
committed
fix: remove final traces of deploy scripts
1 parent d85d3e2 commit b3ac275

11 files changed

Lines changed: 22 additions & 104 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# clas12-timeline
22

3-
Timeline production for CLAS12. Timelines are deployed to [`clas12mon`](https://clas12mon.jlab.org).
3+
Timeline production for CLAS12. Timelines are published to [`clas12mon`](https://clas12mon.jlab.org).
44

55
| Table of Contents | |
66
| --- | --- |

bin/qtl-analysis

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@ if [ ${#failedJobs[@]} -gt 0 ]; then
426426
printError "job '$failedJob' returned non-zero exit code; error log dump:"
427427
cat $logDir/$failedJob.err
428428
if [ "$failedJob" = "hipo-check" ]; then
429-
printWarning "These HIPO files are TIMELINE files; if this '$failedJob' job is the ONLY failed job, you may proceed with timeline deployment, but these failed timelines will not be deployed."
429+
printWarning "These HIPO files are TIMELINE files; they will NOT be published"
430430
fi
431431
done
432432
somethingFailed=true

bin/qtl-physics

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ source $(dirname $0)/../libexec/environ.sh
88
inputDir=""
99
dataset=""
1010
outputDir=""
11+
publishDir=""
1112

1213
# usage
1314
sep="================================================================"
@@ -25,6 +26,8 @@ usage() {
2526
-i [INPUT_DIR] input directory
2627
default = ./outfiles/[DATASET_NAME]
2728
29+
-p [PUBLISH_DIR] publish timeline results (see 'qtl analysis')
30+
2831
OPTIONAL OPTIONS:
2932
3033
-o [OUTPUT_DIR] output directory
@@ -40,14 +43,15 @@ fi
4043

4144
# parse options
4245
helpMode=false
43-
while getopts "d:i:o:h-:" opt; do
46+
while getopts "d:i:p:o:h-:" opt; do
4447
case $opt in
4548
d)
4649
echo $OPTARG | grep -q "/" && printError "dataset name must not contain '/' " && exit 100
4750
dataset=$OPTARG
4851
;;
4952
i) inputDir=$OPTARG ;;
5053
o) outputDir=$OPTARG ;;
54+
p) publishDir=$OPTARG ;;
5155
h) helpMode=true ;;
5256
-)
5357
[ "$OPTARG" != "help" ] && printError "unknown option --$OPTARG"
@@ -65,6 +69,7 @@ fi
6569
[ -z "$inputDir" ] && inputDir=$(pwd -P)/outfiles/$dataset/timeline_physics
6670
[ ! -d $inputDir ] && printError "input directory $inputDir does not exist" && exit 100
6771
[ -z "$outputDir" ] && outputDir=$(realpath $(pwd -P)/outfiles/$dataset) || outputDir=$(realpath $outputDir)
72+
[ -z "$publishDir" ] && printError "need publishing directory, option '-p'" && exit 100
6873

6974
# set subdirectories
7075
qaDir=$outputDir/timeline_physics_qa

doc/dev_notes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ flowchart TB
3939
subgraph Final Timelines
4040
outTimelinePhysics{{outfiles/$dataset/timeline_web/phys_*/*}}:::timeline
4141
outTimelineDetectors{{outfiles/$dataset/timeline_web/$detector/*.hipo}}:::timeline
42-
deploy["<strong>Deployment</strong><br/>qtl deploy"]:::proc
42+
deploy["<strong>Publishing</strong><br/>handled by qtl analysis"]:::proc
4343
timelineDir{{timelines on web server}}:::timeline
4444
end
4545
outplots --> timelineDetectorsPreQA --> outTimelineDetectorsPreQA --> timelineDetectors --> outTimelineDetectors

doc/procedure.md

Lines changed: 4 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -52,23 +52,21 @@ qtl analysis # for detector timelines
5252
qtl physics # for physics timelines (will eventually be combined with 'qtl analysis')
5353
```
5454

55-
> [!IMPORTANT]
55+
> [!TIP]
5656
> If you are processing a large data set on `ifarm`, direct your output files to a location within `/volatile`. Either:
5757
> - make a symbolic link in your working directory named `outfiles` pointing to a location within `/volatile`
5858
> - use the scripts' `-o` option to set the output locations
5959
6060
### Example
6161
**If** you used `clas12-workflow` for Step 1, the script arguments should be
6262
```bash
63-
-d rga_sp19_v5 -i /path/to/output/files
63+
-d rga_sp19_v5 -i /path/to/output/files -p some/publish/directory
6464
```
6565
- the dataset is _given_ the name `"rga_sp19_v5"` (and does not have to be related to any name given from Step 1)
6666
- the output from `clas12-workflow` is `/path/to/output/files`; its subdirectories should be run numbers
67+
- the publish directory given by `-p` is a subdirectory of the web server; see `qtl analysis` usage guide
6768

68-
**Otherwise**, you may omit the `-i /path/to/output/files` option (unless you customized it from Step 1):
69-
```bash
70-
-d rga_sp19_v5
71-
```
69+
**Otherwise**, you may omit the `-i /path/to/output/files` option (unless you customized it from Step 1)
7270
- the dataset name must match that of Step 1, otherwise you need to specify the path to the input files with `-i`
7371

7472

@@ -78,28 +76,3 @@ qtl physics # for physics timelines (will eventually be combined with 'qtl ana
7876
> see [its documentation](/qa-detectors/README.md)
7977
> - physics timeline production and QA are handled by the [`qa-physics/` subdirectory](/qa-physics);
8078
> see [their documentation](/qa-physics/README.md)
81-
82-
<!-- FIXME
83-
we need to remove 'qtl deploy' stuff everywhere...
84-
-->
85-
86-
<!-- ## 🟢 Step 3: Deployment -->
87-
<!---->
88-
<!-- To view the timelines on the web, you must deploy them by copying the timeline HIPO files to a directory with a running web server. Note that you must have write-permission for that directory. To deploy, run (with no arguments, for the usage guide): -->
89-
<!---->
90-
<!-- ```bash -->
91-
<!-- qtl deploy -->
92-
<!-- ``` -->
93-
<!---->
94-
<!-- If all went well, a URL for the new timelines will be printed; open it in a browser to view them. -->
95-
<!---->
96-
<!-- ### Example -->
97-
<!-- ```bash -->
98-
<!-- qtl deploy -d rga_sp19_v5 -t rga/sp19/pass0/v5 -D # deploy to a run-group web directory (for chefs) -->
99-
<!-- ### or ### -->
100-
<!-- qtl deploy -d rga_sp19_v5 -t $LOGNAME/my_test -D # deploy to a personal web directory (for testing) -->
101-
<!-- ``` -->
102-
<!-- - this will _only_ print what will be done: deploy the timelines from dataset `"rga_sp19_v5"` (defined in previous step(s)) to the printed path -->
103-
<!-- - you must have write access to that path; contact the maintainers if you need help with this -->
104-
<!-- - if you are a chef, consider using the appropriate run group subdirectory, _e.g._, `rga/sp19/pass0/v5` -->
105-
<!-- - if it looks correct, remove the `-D` option to deploy for real and follow the printed URL -->

qa-physics/notes/rga_fa18.md

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,6 @@ qtl histogram -d rga_fa18_outbending_nSidis --submit --flatdir --focus-physics /
2828

2929
Make the timelines:
3030
```bash
31-
bin/qtl physics -d rga_fa18_inbending_nSidis
32-
bin/qtl physics -d rga_fa18_outbending_nSidis
33-
```
34-
35-
Deploy either to your area or the common area (remove the `-D` option once you confirm this is the correct directory):
36-
```bash
37-
# your area, for testing
38-
qtl deploy -d rga_fa18_inbending_nSidis -t $LOGNAME -D
39-
qtl deploy -d rga_fa18_outbending_nSidis -t $LOGNAME -D
40-
41-
# common area
42-
qtl deploy -d rga_fa18_inbending_nSidis -t rga/pass2/fa18/qa -D
43-
qtl deploy -d rga_fa18_outbending_nSidis -t rga/pass2/fa18/qa -D
31+
bin/qtl physics -d rga_fa18_inbending_nSidis -p rga/pass2/fa18/qa
32+
bin/qtl physics -d rga_fa18_outbending_nSidis -p rga/pass2/fa18/qa
4433
```

qa-physics/notes/rga_sp19.md

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,6 @@ qtl histogram -d rga_sp19_nSidis --submit --flatdir --focus-physics /cache/clas1
4848

4949
Make the timelines:
5050
```bash
51-
bin/qtl physics -d rga_sp19_prescaled
52-
bin/qtl physics -d rga_sp19_nSidis
53-
```
54-
55-
Deploy either to your area or the common area (remove the `-D` option once you confirm this is the correct directory):
56-
```bash
57-
# your area, for testing
58-
qtl deploy -d rga_sp19_prescaled -t $LOGNAME -D
59-
qtl deploy -d rga_sp19_nSidis -t $LOGNAME -D
60-
61-
# common area
62-
qtl deploy -d rga_sp19_prescaled -t rga/pass2/sp19/qa -D
63-
qtl deploy -d rga_sp19_nSidis -t rga/pass2/sp19/qa -D
51+
bin/qtl physics -d rga_sp19_prescaled -p rga/pass2/sp19/qa
52+
bin/qtl physics -d rga_sp19_nSidis -p rga/pass2/sp19/qa
6453
```

qa-physics/notes/rgb_fa19.md

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,5 @@ qtl histogram -d rgb_fa19_sidisdvcs --submit --flatdir --focus-physics \
3131

3232
Make the timelines:
3333
```bash
34-
bin/qtl physics -d rgb_fa19_sidisdvcs
35-
```
36-
37-
Deploy either to your area or the common area (remove the `-D` option once you confirm this is the correct directory):
38-
```bash
39-
# your area, for testing
40-
qtl deploy -d rgb_fa19_sidisdvcs -t $LOGNAME -D
41-
42-
# common area
43-
qtl deploy -d rgb_fa19_sidisdvcs -t rgb/pass2/qa/fa19 -D
34+
bin/qtl physics -d rgb_fa19_sidisdvcs -p rgb/pass2/qa/fa19
4435
```

qa-physics/notes/rgb_sp19.md

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,5 @@ qtl histogram -d rgb_sp19_sidisdvcs --submit --flatdir --focus-physics /cache/cl
2626

2727
Make the timelines:
2828
```bash
29-
bin/qtl physics -d rgb_sp19_sidisdvcs
30-
```
31-
32-
Deploy either to your area or the common area (remove the `-D` option once you confirm this is the correct directory):
33-
```bash
34-
# your area, for testing
35-
qtl deploy -d rgb_sp19_sidisdvcs -t $LOGNAME -D
36-
37-
# common area
38-
qtl deploy -d rgb_sp19_sidisdvcs -t rgb/pass2/qa/sp19 -D
29+
bin/qtl physics -d rgb_sp19_sidisdvcs -p rgb/pass2/qa/sp19
3930
```

qa-physics/notes/rgb_wi20.md

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,5 @@ qtl histogram -d rgb_wi20_sidisdvcs --submit --flatdir --focus-physics /cache/cl
2626

2727
Make the timelines:
2828
```bash
29-
bin/qtl physics -d rgb_wi20_sidisdvcs
30-
```
31-
32-
Deploy either to your area or the common area (remove the `-D` option once you confirm this is the correct directory):
33-
```bash
34-
# your area, for testing
35-
qtl deploy -d rgb_wi20_sidisdvcs -t $LOGNAME -D
36-
37-
# common area
38-
qtl deploy -d rgb_wi20_sidisdvcs -t rgb/pass2/qa/wi20 -D
29+
bin/qtl physics -d rgb_wi20_sidisdvcs -p rgb/pass2/qa/wi20
3930
```

0 commit comments

Comments
 (0)