Skip to content

Modify forward electron Vz to add target window#464

Merged
c-dilks merged 5 commits intomainfrom
add-target-window
Apr 8, 2026
Merged

Modify forward electron Vz to add target window#464
c-dilks merged 5 commits intomainfrom
add-target-window

Conversation

@zhiwanxu
Copy link
Copy Markdown
Collaborator

@zhiwanxu zhiwanxu commented Apr 8, 2026

  • Add for RGL only: the timeline upstream peak fit (-40,-10), change the rgl-fit function ForwardFitter to be dynamically dependent on the fit range.
  • Add for RGL only: the timeline of target window length: use upstream - downstream (original fit at (10,30))
  • Verified in p0v9 data

Here is the updated selection manul:
Screenshot 2026-04-08 at 12 05 37 PM

Now we have 3 different timeline:
downstream timeline (the default peak in all other run group)
Screenshot 2026-04-08 at 1 59 45 PM

upstream timeline
Screenshot 2026-04-08 at 1 59 31 PM

target window
Screenshot 2026-04-08 at 1 59 38 PM

@zhiwanxu zhiwanxu marked this pull request as ready for review April 8, 2026 19:01
@zhiwanxu zhiwanxu requested a review from c-dilks April 8, 2026 19:01
@c-dilks c-dilks merged commit 5d0d333 into main Apr 8, 2026
9 checks passed
@c-dilks c-dilks deleted the add-target-window branch April 8, 2026 21:07
@c-dilks c-dilks added the rg-l PR for Run Group L label Apr 8, 2026
@zhiwanxu
Copy link
Copy Markdown
Collaborator Author

zhiwanxu commented Apr 8, 2026

@c-dilks I just did a v9 data validation. After I put the 3 quantities in the same forward_electron_VZ.hipo, it generate one timeline figure containing 3 quantities. I think it should be okay.
i.e. below: The 3 data points represents the upstream (-30), downstream (~ 20) and legth (~50).

Screenshot 2026-04-08 at 4 07 58 PM

@c-dilks
Copy link
Copy Markdown
Member

c-dilks commented Apr 8, 2026

Thanks! If these plots end up looking too busy in the full timeline, you could go back to making the two additional HIPO files; I only requested their combination into one HIPO file to try to avoid code duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rg-l PR for Run Group L

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Feature: Track the ALERT target reconstructed window positions and target length

2 participants