fix: handle const Type Parameters#519
Merged
Merged
Conversation
RebeccaStevens
force-pushed
the
issue-518-initial
branch
3 times, most recently
from
372beb6 to
0f27bef
Compare
RebeccaStevens
force-pushed
the
issue-518-initial
branch
from
0f27bef to
4622196
Compare
RebeccaStevens
force-pushed
the
issue-518-initial
branch
from
4622196 to
15445fb
Compare
Collaborator
Author
|
@JoshuaKGoldberg I just cleaned up this PR a bunch and made it a bit more robust. |
RebeccaStevens
force-pushed
the
issue-518-initial
branch
from
15445fb to
0359162
Compare
6 tasks
RebeccaStevens
force-pushed
the
issue-518-initial
branch
from
0359162 to
5b0a2b6
Compare
RebeccaStevens
force-pushed
the
issue-518-initial
branch
from
5b0a2b6 to
74a5952
Compare
JoshuaKGoldberg
approved these changes
Oct 22, 2024
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
Owner
There was a problem hiding this comment.
Sorry for the delay, this looks good to me. Thanks!
JoshuaKGoldberg
force-pushed
the
issue-518-initial
branch
from
1b1deb9 to
9c92710
Compare
Owner
|
Builds are very broken on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
symbolHasReadonlyDeclarationdoesn't supportconsttype parameters #518status: accepting prsOverview
Initial attempt at resolving the issue.
I've got no idea if this is the correct approach or not.
There might be some cases which this PR doesn't currently handle.