Fix renewals on separate containers#165
Merged
Merged
Conversation
|
Wouldn't it make sense to also use the 'NGINX_PROXY_CONTAINER' variable for this case? From a User-perspective I think it's a bit misleading to have two different NGINX container variables. The cases are mutual exclusive, so it should simplify the configuration. |
…newal happend. Reusing the autodetection from --volumes-from.
Contributor
Author
|
At first i tried to avoid the auto-fill to interfere with the NGINX variable. But it makes sense because the auto-fill only detects for a NGINX containter, and not for nginx-proxy. |
Member
|
@JrCs is there something preventing this from being merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in issue #121 there is a bug when there is no new domains added, and needed to SIGHUP nginx container.
This pull requests automatize this reload in this case scenario.
It could be more optimal and only reload nginx container in case no new domains had been found, but sending SIGHUP to nginx container twice doesn't seem like a big cost. At least for a quick short term solution.