make sure we use source column only once#2983
Merged
Conversation
bkamins
changed the title
bkamins
commented
Jan 8, 2022
bkamins
commented
Jan 9, 2022
Member
Author
|
@nalimilan - what do we do with this PR? |
nalimilan
reviewed
Jan 13, 2022
Member
nalimilan
left a comment
nalimilan
left a comment
There was a problem hiding this comment.
Sorry for the delay! How about documenting this in docstrings?
Co-authored-by: Milan Bouchet-Valat <[email protected]>
Member
Author
|
Thank you for careful checking. I have pushed changes in docstring and in comments. |
nalimilan
reviewed
Jan 15, 2022
Co-authored-by: Milan Bouchet-Valat <[email protected]>
nalimilan
approved these changes
Jan 16, 2022
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2978
TODO: add NEWS.md after #2981 is merged.