build(deps): bump actions/checkout from 3 to 4 (libuv#4490)

Requires updating the android builder, since the arm emulator is
deprecated and unavailable now. Switch to using a Github Action plugin
instead of a container, so that hopefully future updates will be
delivered via that channel instead.

Changed the idna test since printf returns EILSEQ for some byte
sequences in the format on Android in glibc. We don't fully understand
the cause, but we can avoid that by not asking it to reencode the bytes
in the current locale settings.

For backport: removing android CI instead, since we don't need it

Author: dependabot[bot]

.github/workflows/CI-unix.yml

@@ -27,24 +27,6 @@ jobs:
         run: |
           make -C build distcheck
 
-  build-android:
-    runs-on: ubuntu-latest
-    container: reactnativecommunity/react-native-android:2020-5-20
-    steps:
-      - uses: actions/checkout@v3
-      - name: Envinfo
-        run: npx envinfo
-      - name: Configure android arm64
-        # see build options you can use in https://developer.android.com/ndk/guides/cmake
-        run: |
-          mkdir build
-          cd build
-          $ANDROID_HOME/cmake/3.10.2.4988404/bin/cmake -DCMAKE_TOOLCHAIN_FILE=$ANDROID_HOME/ndk/20.0.5594570/build/cmake/android.toolchain.cmake -DCMAKE_BUILD_TYPE=Release -DANDROID_ABI="arm64-v8a" -DANDROID_PLATFORM=android-24 ..
-      - name: Build android arm64
-        run: |
-          $ANDROID_HOME/cmake/3.10.2.4988404/bin/cmake --build build
-          ls -lh build
-
   build-macos:
     runs-on: ${{ matrix.os }}
     strategy:

test/test-idna.c

@@ -39,55 +39,55 @@ TEST_IMPL(utf8_decode1) {
 
   /* Two-byte sequences. */
   p = b;
-  snprintf(b, sizeof(b), "\xC2\x80\xDF\xBF");
+  snprintf(b, sizeof(b), "%s", "\xC2\x80\xDF\xBF");
   ASSERT_EQ(128, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 2);
   ASSERT_EQ(0x7FF, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 4);
 
   /* Three-byte sequences. */
   p = b;
-  snprintf(b, sizeof(b), "\xE0\xA0\x80\xEF\xBF\xBF");
+  snprintf(b, sizeof(b), "%s", "\xE0\xA0\x80\xEF\xBF\xBF");
   ASSERT_EQ(0x800, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 3);
   ASSERT_EQ(0xFFFF, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 6);
 
   /* Four-byte sequences. */
   p = b;
-  snprintf(b, sizeof(b), "\xF0\x90\x80\x80\xF4\x8F\xBF\xBF");
+  snprintf(b, sizeof(b), "%s", "\xF0\x90\x80\x80\xF4\x8F\xBF\xBF");
   ASSERT_EQ(0x10000, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 4);
   ASSERT_EQ(0x10FFFF, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 8);
 
   /* Four-byte sequences > U+10FFFF; disallowed. */
   p = b;
-  snprintf(b, sizeof(b), "\xF4\x90\xC0\xC0\xF7\xBF\xBF\xBF");
+  snprintf(b, sizeof(b), "%s", "\xF4\x90\xC0\xC0\xF7\xBF\xBF\xBF");
   ASSERT_EQ((unsigned) -1, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 4);
   ASSERT_EQ((unsigned) -1, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 8);
 
   /* Overlong; disallowed. */
   p = b;
-  snprintf(b, sizeof(b), "\xC0\x80\xC1\x80");
+  snprintf(b, sizeof(b), "%s", "\xC0\x80\xC1\x80");
   ASSERT_EQ((unsigned) -1, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 2);
   ASSERT_EQ((unsigned) -1, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 4);
 
   /* Surrogate pairs; disallowed. */
   p = b;
-  snprintf(b, sizeof(b), "\xED\xA0\x80\xED\xA3\xBF");
+  snprintf(b, sizeof(b), "%s", "\xED\xA0\x80\xED\xA3\xBF");
   ASSERT_EQ((unsigned) -1, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 3);
   ASSERT_EQ((unsigned) -1, uv__utf8_decode1(&p, b + sizeof(b)));
   ASSERT_PTR_EQ(p, b + 6);
 
   /* Simply illegal. */
   p = b;
-  snprintf(b, sizeof(b), "\xF8\xF9\xFA\xFB\xFC\xFD\xFE\xFF");
+  snprintf(b, sizeof(b), "%s", "\xF8\xF9\xFA\xFB\xFC\xFD\xFE\xFF");
 
   for (i = 1; i <= 8; i++) {
     ASSERT_EQ((unsigned) -1, uv__utf8_decode1(&p, b + sizeof(b)));

test/test-udp-multicast-join.c

@@ -161,6 +161,10 @@ TEST_IMPL(udp_multicast_join) {
   if (r == UV_ENODEV)
     RETURN_SKIP("No multicast support.");
   ASSERT_OK(r);
+#if defined(__ANDROID__)
+  /* It returns an ENOSYS error */
+  RETURN_SKIP("Test does not currently work in ANDROID");
+#endif
 
   r = uv_udp_recv_start(&server, alloc_cb, cl_recv_cb);
   ASSERT_OK(r);