fix(DataMapper): Do not remove InstructionItem targeted field item

Fixes: #3149

Author: igarashitm

packages/ui/src/services/mapping.service.test.ts

@@ -300,6 +300,18 @@ describe('MappingService', () => {
       consoleSpy.mockRestore();
       extractSpy.mockRestore();
     });
+
+    it("should not remove for-each targeted field when it doesn't have children", () => {
+      const shipOrderItem = tree.children[0];
+      const forEachItem = shipOrderItem.children[3];
+      expect(forEachItem).toBeInstanceOf(ForEachItem);
+      shipOrderItem.children = [forEachItem];
+      const itemItem = forEachItem.children[0];
+      itemItem.children = [];
+      MappingService.removeAllMappingsForDocument(tree, DocumentType.PARAM, 'newParam');
+      expect(forEachItem.children.length).toEqual(1);
+      expect(forEachItem.children[0]).toBe(itemItem);
+    });
   });
 
   describe('renameParameterInMappings()', () => {

packages/ui/src/services/mapping.service.ts

@@ -102,7 +102,8 @@ export class MappingService {
       ) {
         return acc;
       }
-      if (child instanceof FieldItem && child.children.length === 0) return acc;
+      if (!(child.parent instanceof InstructionItem) && child instanceof FieldItem && child.children.length === 0)
+        return acc;
       acc.push(child);
       return acc;
     }, [] as MappingItem[]);