Remove bloat

Author: Kaweees

examples/train.zig

@@ -4,25 +4,10 @@
 
 const std = @import("std");
 const kiwigrad = @import("kiwigrad");
+const zbench = @import("zbench");
 
 const print = std.debug.print;
 
-/// Write the computational graph to a Graphviz file
-pub fn draw_graph(comptime T: type, graph: *kiwigrad.engine.Value(T), name: []const u8, writer: anytype) !void {
-    const dot_name = try std.fmt.allocPrint(std.heap.page_allocator, "{s}.dot", .{name});
-    defer std.heap.page_allocator.free(dot_name);
-    const png_name = try std.fmt.allocPrint(std.heap.page_allocator, "{s}.png", .{name});
-    defer std.heap.page_allocator.free(png_name);
-
-    const file = try std.fs.cwd().createFile(dot_name, .{});
-    defer file.close();
-    const file_writer = file.writer();
-    try graph.draw_dot(file_writer, std.heap.page_allocator);
-
-    try writer.print("Computational graph written to {s}\n", .{dot_name});
-    try writer.print("You can visualize it by running: dot -Tpng {s} -o {s}\n", .{ dot_name, png_name });
-}
-
 pub fn main() !void {
     const stdout_file = std.io.getStdOut().writer();
     var bw = std.io.bufferedWriter(stdout_file);
@@ -71,6 +56,6 @@ pub fn main() !void {
     print("output.data: {d:.4}\n", .{output.data});
     print("output.grad: {d:.4}\n", .{output.grad});
 
-    try draw_graph(f64, output, "assets/img/train", stdout);
+    output.draw_graph("assets/img/train", stdout);
     try bw.flush(); // Don't forget to flush!
 }

src/engine.zig

@@ -341,21 +341,18 @@ pub fn Value(comptime T: type) type {
 
         /// Write the computational graph to a Graphviz file
         pub fn draw_graph(graph: *Self, name: []const u8, writer: anytype) void {
-            const dot_name = try std.fmt.allocPrint(std.heap.page_allocator, "{s}.dot", .{name});
+            const dot_name = std.fmt.allocPrint(std.heap.page_allocator, "{s}.dot", .{name}) catch unreachable;
             defer std.heap.page_allocator.free(dot_name);
-            const png_name = try std.fmt.allocPrint(std.heap.page_allocator, "{s}.png", .{name});
+            const png_name = std.fmt.allocPrint(std.heap.page_allocator, "{s}.png", .{name}) catch unreachable;
             defer std.heap.page_allocator.free(png_name);
 
-            const file = try std.fs.cwd().createFile(dot_name, .{});
+            const file = std.fs.cwd().createFile(dot_name, .{}) catch unreachable;
             defer file.close();
             const file_writer = file.writer();
-            graph.draw_dot(file_writer, std.heap.page_allocator) catch |err| {
-                std.debug.print("Failed to write dot file: {}\n", .{err});
-                return;
-            };
+            graph.draw_dot(file_writer, std.heap.page_allocator) catch unreachable;
 
-            try writer.print("Computational graph written to {s}\n", .{dot_name});
-            try writer.print("You can visualize it by running: dot -Tpng {s} -o {s}\n", .{ dot_name, png_name });
+            writer.print("Computational graph written to {s}\n", .{dot_name}) catch unreachable;
+            writer.print("You can visualize it by running: dot -Tpng {s} -o {s}\n", .{ dot_name, png_name }) catch unreachable;
         }
     };
 }

src/nn.zig

@@ -164,6 +164,7 @@ pub fn Layer(comptime T: type) type {
             }
 
             layer.* = Self{
+                .nin = nin,
                 .neurons = neurons[0..],
                 .nout = nout,
             };
@@ -174,7 +175,6 @@ pub fn Layer(comptime T: type) type {
         /// Forward pass through the layer
         pub fn forward(self: *Self, inputs: []*ValueType) []*ValueType {
             var list = arena.allocator().alloc(*ValueType, self.nout) catch unreachable;
-            defer arena.allocator().free(list);
             for (self.neurons, 0..) |neuron, i| {
                 list[i] = neuron.forward(inputs);
             }