feedback

Author: sfierro

libs/core/kiln_ai/cli/commands/package_project.py

@@ -864,7 +864,11 @@ def package_project(
             )
 
         # 6. Export required skills
-        export_skills(required_skill_ids, project, exported_project)
+        try:
+            export_skills(required_skill_ids, project, exported_project)
+        except ValueError as e:
+            console.print(f"[red]Error exporting skills: {e}")
+            raise typer.Exit(code=1)
         if required_skill_ids:
             console.print(
                 f"[green]✓[/green] Exported {len(required_skill_ids)} skill(s)"

libs/core/kiln_ai/cli/commands/test_package_project.py

@@ -1468,6 +1468,17 @@ def test_no_skills_for_builtin_tools(self, temp_project_with_builtin_tool):
 
         assert len(skill_ids) == 0
 
+    def test_skips_task_without_run_config(
+        self, temp_project_with_skill_tool: SkillToolProjectFixture
+    ) -> None:
+        """Test that tasks without a matching run config are skipped."""
+        task = Task.load_from_file(temp_project_with_skill_tool["task"].path)
+
+        assert task.id is not None
+        skill_ids = collect_required_skills([task], {})
+
+        assert len(skill_ids) == 0
+
 
 class TestExportSkills:
     def test_exports_skill(
@@ -1510,6 +1521,57 @@ def test_exports_no_skills_when_empty(self, temp_project):
         finally:
             shutil.rmtree(temp_dir, ignore_errors=True)
 
+    def test_raises_when_exported_project_path_is_none(
+        self, temp_project_with_skill_tool: SkillToolProjectFixture
+    ) -> None:
+        """Test that export_skills raises when exported project path is None."""
+        project = temp_project_with_skill_tool["project"]
+        skill = temp_project_with_skill_tool["skill"]
+        exported_project = Project(name="No Path Project", path=None)
+
+        assert skill.id is not None
+        with pytest.raises(ValueError, match="Exported project path is not set"):
+            export_skills({skill.id}, project, exported_project)
+
+    def test_raises_when_skill_id_not_found(
+        self, temp_project_with_skill_tool: SkillToolProjectFixture
+    ) -> None:
+        """Test that export_skills raises when a skill ID is not in the project."""
+        import shutil
+
+        project = temp_project_with_skill_tool["project"]
+        temp_dir, exported_project = create_export_directory(project)
+
+        try:
+            with pytest.raises(ValueError, match=r"Skill ID.*not found in the project"):
+                export_skills({"nonexistent_id"}, project, exported_project)
+        finally:
+            shutil.rmtree(temp_dir, ignore_errors=True)
+
+    def test_raises_when_skill_path_is_none(
+        self, temp_project_with_skill_tool: SkillToolProjectFixture
+    ) -> None:
+        """Test that export_skills raises when a skill's path is None."""
+        import shutil
+        from unittest.mock import MagicMock
+
+        project = temp_project_with_skill_tool["project"]
+        skill = temp_project_with_skill_tool["skill"]
+        temp_dir, exported_project = create_export_directory(project)
+
+        try:
+            assert skill.id is not None
+            fake_skill = MagicMock()
+            fake_skill.id = skill.id
+            fake_skill.name = skill.name
+            fake_skill.path = None
+
+            with patch.object(Project, "skills", return_value=[fake_skill]):
+                with pytest.raises(ValueError, match="path is not set"):
+                    export_skills({skill.id}, project, exported_project)
+        finally:
+            shutil.rmtree(temp_dir, ignore_errors=True)
+
 
 class TestExportToolServers:
     def test_exports_tool_server(self, temp_project_with_mcp_remote_tool):