Skip to content

Commit 576e8b0

Browse files
committed
fixed add feedback dialog UI
1 parent 955a9e5 commit 576e8b0

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

app/web_ui/src/lib/utils/form_element.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
export let empty_state_link: string | null = null
4545
export let inline_action: InlineAction | null = null
4646
export let aria_label: string | null = null
47+
export let hide_label: boolean = false
4748
4849
function is_empty(value: unknown): boolean {
4950
if (value === null || value === undefined) {
@@ -157,7 +158,7 @@
157158
{disabled}
158159
/>
159160
{/if}
160-
{#if label || inline_action || info_description || error_message || description}
161+
{#if !hide_label && (label || inline_action || info_description || error_message || description)}
161162
<label
162163
for={id}
163164
class="text-sm font-medium text-left flex flex-col gap-1 w-full"

app/web_ui/src/routes/(app)/run/run.svelte

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -725,19 +725,20 @@
725725
<Dialog
726726
bind:this={add_feedback_dialog}
727727
title="Add Feedback"
728+
sub_subtitle="Comment on the model's output."
728729
on:close={() => (add_feedback_open = false)}
729730
>
730731
{#if add_feedback_open}
731732
<FormContainer
732-
submit_label="Add"
733+
submit_label="Save Feedback"
733734
on:submit={submit_feedback}
734735
bind:submitting={add_feedback_submitting}
735736
bind:error={add_feedback_error}
736737
>
737738
<FormElement
738739
id="new_feedback_input"
740+
hide_label={true}
739741
label="Feedback"
740-
info_description="Feedback you have on the output."
741742
inputType="textarea"
742743
bind:value={new_feedback_text}
743744
/>

0 commit comments

Comments
 (0)