Merge pull request #1155 from Kiln-AI/KIL-471/create-run-config-error

fix: propagate actual errors from save_new_run_config

Author: sfierro

app/web_ui/src/lib/ui/run_config_component/create_new_run_config_dialog.svelte

@@ -55,13 +55,12 @@
     submitting = true
     try {
       save_config_error = null
-      const saved_run_config = await run_config_component?.save_new_run_config()
-      if (saved_run_config) {
-        new_run_config_created?.(saved_run_config)
-        close() // Only close on success
-      } else {
-        throw new Error("Resulting saved run config not found.")
+      if (!run_config_component) {
+        throw new Error("Run configuration component is not loaded")
       }
+      const saved_run_config = await run_config_component.save_new_run_config()
+      new_run_config_created?.(saved_run_config)
+      close() // Only close on success
     } catch (e) {
       save_config_error = createKilnError(e)
     } finally {

app/web_ui/src/lib/ui/run_config_component/run_config_component.svelte

@@ -10,7 +10,6 @@
     run_configs_by_task_composite_id,
     save_new_task_run_config,
   } from "$lib/stores/run_configs_store"
-  import { createKilnError } from "$lib/utils/error_handlers"
   import { KilnError } from "$lib/utils/error_handlers"
   import type {
     RunConfigProperties,
@@ -47,7 +46,6 @@
   export let tools_selector_settings: Partial<ToolsSelectorSettings> = {}
   export let skills_selector_settings: Partial<SkillsSelectorSettings> = {}
   export let selected_run_config_id: string | null = null
-  export let save_config_error: KilnError | null = null
   export let set_default_error: KilnError | null = null
   export let hide_prompt_selector: boolean = false
   export let hide_tools_selector: boolean = false
@@ -393,28 +391,22 @@
     }
   }
 
-  export async function save_new_run_config(): Promise<TaskRunConfig | null> {
+  export async function save_new_run_config(): Promise<TaskRunConfig> {
     if (!current_task?.id) {
-      return null
+      throw new Error("Cannot save run config: no task selected")
     }
-    try {
-      save_config_error = null
-      const saved_config = await save_new_task_run_config(
-        project_id,
-        current_task.id,
-        run_options_as_run_config_properties(),
-        run_config_name,
-      )
-      // Reload prompts to update the dropdown with the new static prompt that is made from saving a new run config
-      await load_task_prompts(project_id, current_task.id, true)
-      if (!saved_config || !saved_config.id) {
-        throw new Error("Saved config id not found")
-      }
-      return saved_config
-    } catch (e) {
-      save_config_error = createKilnError(e)
+    const saved_config = await save_new_task_run_config(
+      project_id,
+      current_task.id,
+      run_options_as_run_config_properties(),
+      run_config_name,
+    )
+    // Reload prompts to update the dropdown with the new static prompt that is made from saving a new run config
+    await load_task_prompts(project_id, current_task.id, true)
+    if (!saved_config || !saved_config.id) {
+      throw new Error("Saved config id not found")
     }
-    return null
+    return saved_config
   }
 
   async function get_selected_run_config(): Promise<
@@ -450,7 +442,6 @@
   }
 
   export function clear_run_options_errors() {
-    save_config_error = null
     set_default_error = null
   }
 

app/web_ui/src/lib/ui/run_config_component/saved_run_configs_dropdown.svelte

@@ -36,8 +36,7 @@
   export let project_id: string
   export let current_task: Task
   export let selected_run_config_id: string | null = null // This will be null until the default_run_config_id is set
-  export let save_new_run_config: (() => Promise<TaskRunConfig | null>) | null =
-    null
+  export let save_new_run_config: (() => Promise<TaskRunConfig>) | null = null
   export let save_config_error: KilnError | null = null
   export let set_default_error: KilnError | null = null
   export let info_description: string = ""
@@ -248,7 +247,7 @@
   async function handle_save() {
     if (save_new_run_config) {
       const saved_run_config = await save_new_run_config()
-      if (saved_run_config?.id) {
+      if (saved_run_config.id) {
         selected_run_config_id = saved_run_config.id
       }
     }

app/web_ui/src/routes/(app)/optimize/[project_id]/[task_id]/run_config/create/+page.svelte

@@ -67,10 +67,7 @@
     submitting = true
     try {
       save_config_error = null
-      const saved_config = await run_config_component?.save_new_run_config()
-      if (!saved_config) {
-        throw new Error("Failed to save run config")
-      }
+      await run_config_component?.save_new_run_config()
       goto(`/optimize/${project_id}/${task_id}`)
     } catch (e) {
       save_config_error = createKilnError(e)

app/web_ui/src/routes/(app)/run/+page.svelte

@@ -166,16 +166,11 @@
     }
   }
 
-  async function handle_save_new_run_config(): Promise<TaskRunConfig | null> {
-    try {
-      if (!run_config_component) {
-        throw new Error("Run configuration component is not loaded")
-      }
-      return await run_config_component.save_new_run_config()
-    } catch (e) {
-      save_config_error = createKilnError(e)
+  async function handle_save_new_run_config(): Promise<TaskRunConfig> {
+    if (!run_config_component) {
+      throw new Error("Run configuration component is not loaded")
     }
-    return null
+    return await run_config_component.save_new_run_config()
   }
 
   function handle_input_change() {
@@ -228,7 +223,6 @@
             current_task={$current_task}
             requires_structured_output={!!$current_task.output_json_schema}
             bind:selected_run_config_id
-            bind:save_config_error
             bind:set_default_error
             bind:selected_model_specific_run_config_id
             {pending_tool_id}