feedback

Author: sfierro

app/web_ui/src/routes/(fullscreen)/setup/(setup)/create_task/edit_task.svelte

@@ -48,16 +48,16 @@
 
   // Track initial values to detect actual changes from the loaded state.
   // This prevents false "unsaved changes" warnings when opening an existing task.
-  let initial_name = task.name
-  let initial_description = task.description
-  let initial_instruction = task.instruction
-  let initial_thinking_instruction = task.thinking_instruction
-  let initial_requirements = task.requirements.map((r) => ({
-    name: r.name,
-    instruction: r.instruction,
-    type: r.type,
-    priority: r.priority,
-  }))
+  let initial_name: string
+  let initial_description: string | null | undefined
+  let initial_instruction: string
+  let initial_thinking_instruction: string | null | undefined
+  let initial_requirements: Array<{
+    name: string | undefined
+    instruction: string | undefined
+    type: string | undefined
+    priority: number | undefined
+  }>
 
   function reset_initial_values() {
     initial_name = task.name
@@ -71,6 +71,7 @@
       priority: r.priority,
     }))
   }
+  reset_initial_values()
 
   function requirements_changed(
     reqs: Task["requirements"],
@@ -79,21 +80,21 @@
     if (reqs.length !== initial.length) return true
     return reqs.some(
       (r, i) =>
-        r.name !== initial[i].name ||
-        r.instruction !== initial[i].instruction ||
-        r.type !== initial[i].type ||
+        (r.name || "") !== (initial[i].name || "") ||
+        (r.instruction || "") !== (initial[i].instruction || "") ||
+        (r.type || "") !== (initial[i].type || "") ||
         r.priority !== initial[i].priority,
     )
   }
 
   // Warn before unload only if there are actual changes from the initial state
   $: warn_before_unload =
-    !saved &&
-    (task.name !== initial_name ||
-      task.description !== initial_description ||
-      task.instruction !== initial_instruction ||
-      task.thinking_instruction !== initial_thinking_instruction ||
-      requirements_changed(task.requirements, initial_requirements))
+    task.name !== initial_name ||
+    (task.description || "") !== (initial_description || "") ||
+    task.instruction !== initial_instruction ||
+    (task.thinking_instruction || "") !==
+      (initial_thinking_instruction || "") ||
+    requirements_changed(task.requirements, initial_requirements)
 
   // Allow explicitly setting project ID, or infer current project ID
   export let explicit_project_id: string | undefined = undefined