CR from gemini

Author: chiang-daniel

libs/server/kiln_server/custom_errors.py

@@ -89,13 +89,14 @@ async def http_exception_handler(request: Request, exc: HTTPException):
 
     @app.exception_handler(httpx.TimeoutException)
     async def timeout_error_handler(request: Request, exc: httpx.TimeoutException):
+        logger.warning(
+            f"Request timed out on {request.method} {request.url.path}",
+            exc_info=exc,
+        )
         return JSONResponse(
             status_code=status.HTTP_408_REQUEST_TIMEOUT,
             headers={"Access-Control-Allow-Origin": "*"},
-            content={
-                "message": "Request timed out. Please try again.",
-                "raw_error": str(exc),
-            },
+            content={"message": "Request timed out. Please try again."},
         )
 
     # Fallback error handler for any other exception

libs/server/kiln_server/test_custom_error.py

@@ -109,18 +109,18 @@ def test_format_error_loc_with_empty_string():
 
 
 class TestTimeoutErrorHandler:
-    def test_timeout_exception_returns_408(self, client):
-        response = client.get("/timeout")
+    def test_timeout_exception_returns_408(self, client_no_raise):
+        response = client_no_raise.get("/timeout")
         assert response.status_code == 408
 
-    def test_timeout_exception_message(self, client):
-        response = client.get("/timeout")
+    def test_timeout_exception_message(self, client_no_raise):
+        response = client_no_raise.get("/timeout")
         body = response.json()
         assert body["message"] == "Request timed out. Please try again."
-        assert "raw_error" in body
+        assert "raw_error" not in body
 
-    def test_timeout_exception_has_cors_header(self, client):
-        response = client.get("/timeout")
+    def test_timeout_exception_has_cors_header(self, client_no_raise):
+        response = client_no_raise.get("/timeout")
         assert response.headers.get("access-control-allow-origin") == "*"
 
     def test_other_exceptions_still_return_500(self, client_no_raise):