Commit 513af3b
fix: address Copilot review feedback on moveTicket + sprint filter
- moveTicket: pass null (not '') to the nullable integer columns
sprint/dependingTicketId/milestoneid so Postgres accepts the clear;
check the child patch() return value and short-circuit on failure
so a milestone can't end up half-moved; drop the duplicate
ticket_updated dispatch since patch() already fires it on success.
- Sprint filter (both call sites in Tickets repo): replace the
is_numeric guard with per-element ctype_digit validation so
comma-separated multi-sprint filters like "1,2,3" work again,
while 'backlog' / empty / non-digit values still fall through to
the dedicated backlog branch.
Addresses review comments on #3360.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 66e1258 commit 513af3b
2 files changed
Lines changed: 33 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
561 | 561 | | |
562 | 562 | | |
563 | 563 | | |
564 | | - | |
565 | | - | |
566 | | - | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
567 | 573 | | |
568 | 574 | | |
569 | 575 | | |
| |||
1224 | 1230 | | |
1225 | 1231 | | |
1226 | 1232 | | |
1227 | | - | |
1228 | | - | |
1229 | | - | |
1230 | | - | |
1231 | | - | |
1232 | | - | |
| 1233 | + | |
| 1234 | + | |
| 1235 | + | |
| 1236 | + | |
| 1237 | + | |
| 1238 | + | |
| 1239 | + | |
| 1240 | + | |
| 1241 | + | |
| 1242 | + | |
| 1243 | + | |
| 1244 | + | |
| 1245 | + | |
1233 | 1246 | | |
1234 | 1247 | | |
1235 | 1248 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2235 | 2235 | | |
2236 | 2236 | | |
2237 | 2237 | | |
2238 | | - | |
| 2238 | + | |
| 2239 | + | |
| 2240 | + | |
| 2241 | + | |
| 2242 | + | |
| 2243 | + | |
| 2244 | + | |
| 2245 | + | |
2239 | 2246 | | |
2240 | 2247 | | |
2241 | 2248 | | |
2242 | | - | |
2243 | | - | |
2244 | 2249 | | |
2245 | 2250 | | |
2246 | | - | |
2247 | | - | |
2248 | | - | |
| 2251 | + | |
| 2252 | + | |
| 2253 | + | |
2249 | 2254 | | |
2250 | 2255 | | |
2251 | 2256 | | |
| |||
0 commit comments