Fixing resend verification email. (#6470)

* Fixing resend verification email.

* Clippy

Author: dessalines

crates/api/api/src/local_user/resend_verification_email.rs

@@ -12,13 +12,22 @@ pub async fn resend_verification_email(
   Json(data): Json<ResendVerificationEmail>,
   context: Data<LemmyContext>,
 ) -> LemmyResult<Json<SuccessResponse>> {
-  let site_view = SiteView::read_local(&mut context.pool()).await?;
   let email = data.email.to_string();
 
+  // For security, errors are not returned.
+  // https://github.com/LemmyNet/lemmy/issues/5277
+  let _ = try_resend_verification_email(&email, &context).await;
+
+  Ok(Json(SuccessResponse::default()))
+}
+
+async fn try_resend_verification_email(email: &str, context: &LemmyContext) -> LemmyResult<()> {
   // Fetch that email
-  let local_user_view = LocalUserView::find_by_email(&mut context.pool(), &email).await?;
+  let local_user_view = LocalUserView::find_by_email(&mut context.pool(), email).await?;
   check_local_user_valid(&local_user_view)?;
 
+  let site_view = SiteView::read_local(&mut context.pool()).await?;
+
   send_verification_email_if_required(
     &site_view.local_site,
     &local_user_view,
@@ -27,5 +36,5 @@ pub async fn resend_verification_email(
   )
   .await?;
 
-  Ok(Json(SuccessResponse::default()))
+  Ok(())
 }