Skip to content

Commit e18d5c7

Browse files
committed
Breaking: also drop Node.js 16 and Electron < 30
Follow-up for c177f3c. Older Electron versions will still work fine, but we stop testing them. Category: removal
1 parent 20efc35 commit e18d5c7

6 files changed

Lines changed: 9 additions & 27 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,8 @@ jobs:
3939
- name: Set up node
4040
uses: actions/setup-node@v4
4141
with:
42-
node-version: 16
42+
node-version: 18
4343
architecture: ${{ matrix.arch }}
44-
# Temporary fix for https://github.com/nodejs/node-gyp/issues/2869
45-
# TODO: instead bump node-gyp to >= 10.0.0 (drops Node.js < 16.14)
46-
- name: Use Python 3.11
47-
uses: actions/setup-python@v5
48-
with:
49-
python-version: '3.11'
5044
- name: Install
5145
run: npm install --ignore-scripts
5246
- name: Prebuild

.github/workflows/smoke.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,8 @@ jobs:
4141
- name: Set up node
4242
uses: actions/setup-node@v4
4343
with:
44-
node-version: 16
44+
node-version: 18
4545
architecture: ${{ matrix.arch }}
46-
# Temporary fix for https://github.com/nodejs/node-gyp/issues/2869
47-
# TODO: instead bump node-gyp to >= 10.0.0 (drops Node.js < 16.14)
48-
- name: Use Python 3.11
49-
uses: actions/setup-python@v5
50-
with:
51-
python-version: '3.11'
5246
- name: Install
5347
run: npm install --ignore-scripts
5448
- name: Prebuild

.github/workflows/test.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
strategy:
88
matrix:
99
os: [ubuntu-latest, macos-latest, windows-latest]
10-
node: [16, 18, 20]
10+
node: [18, 20, 22]
1111
arch: [x86, x64]
1212
exclude:
1313
- { os: ubuntu-latest, arch: x86 }
@@ -24,12 +24,6 @@ jobs:
2424
with:
2525
node-version: ${{ matrix.node }}
2626
architecture: ${{ matrix.arch }}
27-
# Temporary fix for https://github.com/nodejs/node-gyp/issues/2869
28-
# TODO: instead bump node-gyp to >= 10.0.0 (drops Node.js < 16.14)
29-
- name: Use Python 3.11
30-
uses: actions/setup-python@v5
31-
with:
32-
python-version: '3.11'
3327
- name: Install
3428
run: npm install
3529
- name: Test
@@ -41,7 +35,7 @@ jobs:
4135
with:
4236
file: coverage/lcov.info
4337
- name: Test Electron
44-
if: ${{ matrix.node == '16' }}
38+
if: ${{ matrix.node == '18' }}
4539
uses: GabrielBB/xvfb-action@v1
4640
with:
4741
run: npm run test-electron

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const xyz = db.sublevel<string, any>('xyz', { valueEncoding: 'json' })
9191

9292
## Supported Platforms
9393

94-
We aim to support _at least_ Active LTS and Current Node.js releases, Electron >= 18, as well as any future Node.js and Electron releases thanks to [Node-API](https://nodejs.org/api/n-api.html).
94+
We aim to support Active LTS and Current Node.js releases, Electron >= 30, as well as any future Node.js and Electron releases thanks to [Node-API](https://nodejs.org/api/n-api.html).
9595

9696
The `classic-level` npm package ships with prebuilt binaries for popular 64-bit platforms as well as ARM, M1, Android (built against Node.js core rather than the [`nodejs-mobile`](https://github.com/JaneaSystems/nodejs-mobile) fork), Alpine (musl), Windows 32-bit, Linux flavors with an old glibc (Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7) and is known to work on:
9797

UPGRADING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This document describes breaking changes and how to upgrade. For a complete list
44

55
## 2.0.0
66

7-
This release upgrades to `abstract-level` 2.0.0 which adds [hooks](https://github.com/Level/abstract-level#hooks) and drops callbacks, not-found errors and support of Node.js < 16. Please refer to the [upgrade guide of `abstract-level`](https://github.com/Level/abstract-level/blob/v2.0.0/UPGRADING.md). The only thing to add is that the additional methods of `classic-level` like `db.approximateSize()` also don't support callbacks anymore.
7+
This release upgrades to `abstract-level` 2.0.0 which adds [hooks](https://github.com/Level/abstract-level#hooks) and drops callbacks, not-found errors and support of Node.js < 16. Please refer to the [upgrade guide of `abstract-level`](https://github.com/Level/abstract-level/blob/v2.0.0/UPGRADING.md). The only thing to add is that `classic-level` also drops Node.js 16 and Electron < 30, and that the additional methods of `classic-level` like `db.approximateSize()` similarly don't support callbacks anymore.
88

99
## 1.0.0
1010

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@
3838
"cross-env": "^7.0.3",
3939
"dependency-check": "^4.1.0",
4040
"du": "^1.0.0",
41-
"electron": "^18.3.15",
41+
"electron": "^30.5.1",
4242
"glob": "^8.0.1",
4343
"hallmark": "^4.1.0",
4444
"mkfiletree": "^2.0.0",
45-
"node-gyp": "^9.0.0",
45+
"node-gyp": "^10.2.0",
4646
"nyc": "^15.0.0",
4747
"prebuildify": "^5.0.0",
4848
"prebuildify-ci": "^1.0.4",
@@ -66,6 +66,6 @@
6666
"level"
6767
],
6868
"engines": {
69-
"node": ">=16"
69+
"node": ">=18"
7070
}
7171
}

0 commit comments

Comments
 (0)