This repository was archived by the owner on Dec 2, 2024. It is now read-only.
Use setImmediate with callback in _close()#111
Merged
ralphtheninja merged 1 commit intomasterfrom May 27, 2018
Merged
Conversation
vweevers
approved these changes
May 26, 2018
Member
|
Breaks the destroy tests. |
Merged
Member
I suspect that has something to with |
Member
|
Confirmed. We have a few options:
|
c1c25be to
1350be6
Compare
Member
Author
|
Yes I just found the same problem. Since we do |
Member
Let's go with that 👍 |
Member
Author
|
I'll keep this PR open and fix that first. |
1350be6 to
7163ec3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109