Skip to content
This repository was archived by the owner on Dec 2, 2024. It is now read-only.

Mention that null and undefined values are not supported#125

Merged
vweevers merged 1 commit intomasterfrom
mention-nullish
May 27, 2018
Merged

Mention that null and undefined values are not supported#125
vweevers merged 1 commit intomasterfrom
mention-nullish

Conversation

@vweevers
Copy link
Copy Markdown
Member

Closes #105.

@vweevers vweevers requested a review from ralphtheninja May 27, 2018 14:05
Comment thread README.md
- Support [Buffer](https://nodejs.org/api/buffer.html) values (in all target environments)
- Support all key types of IndexedDB Second Edition, including binary keys (depends on environment)
- Support all value types of the structured clone algorithm (depends on environment)
- Support all value types of the structured clone algorithm (depends on environment) except for `null` and `undefined`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention something about writing them as empty strings if they are used as values?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We can do that as part of #123

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(which is a bigger effort)

@vweevers vweevers merged commit 3a8b861 into master May 27, 2018
@vweevers vweevers deleted the mention-nullish branch May 27, 2018 14:14
@vweevers vweevers mentioned this pull request May 27, 2018
@vweevers vweevers added the upgrade guide Improvements or additions to upgrade guide(s) label Jun 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

upgrade guide Improvements or additions to upgrade guide(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants