Fix getMany() memory leak

vweevers · vweevers · commit 6cbf8b0946d0 · 2022-03-24T23:30:35.000+01:00
Ref Level/rocksdb#192 Ref #790
diff --git a/binding.cc b/binding.cc
@@ -260,6 +260,7 @@ static std::vector<std::string>* KeyArray (napi_env env, napi_value arr) {
           StringOrBufferLength(env, element) > 0) {
         LD_STRING_OR_BUFFER_TO_COPY(env, element, to);
         result->emplace_back(toCh_, toSz_);
+        delete [] toCh_;
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -260,6 +260,7 @@ static std::vector<std::string>* KeyArray (napi_env env, napi_value arr) {`
`260`	`260`	`StringOrBufferLength(env, element) > 0) {`
`261`	`261`	`LD_STRING_OR_BUFFER_TO_COPY(env, element, to);`
`262`	`262`	`result->emplace_back(toCh_, toSz_);`
	`263`	`+ delete [] toCh_;`
`263`	`264`	`}`
`264`	`265`	`}`
`265`	`266`	`}`